test: move some library event tests from test_api to test_events [FC-0117]#38407
test: move some library event tests from test_api to test_events [FC-0117]#38407bradenmacdonald wants to merge 1 commit intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
92695ae to
036c415
Compare
|
@ormsbee @kdmccormick Could I please get a review from one of you on this PR? It is just refactoring the content libraries event tests, without any changes to how the events work. This change will make it much easier to validate my other PRs that majorly refactor how the library events get emitted. |
Description
To make my other PR openedx/openedx-core#543 easier to review, and easier to compare its before-and-after effects, this PR moves some content libraries tests from
test_api.pytotest_events.py, updates them to match the style and detail of the other events tests, and makes them more comprehensive by adding theCONTENT_OBJECT_ASSOCIATIONS_CHANGEDevent to the event tests, which were previously ignoring it.This addresses the longstanding TODO in the code:
openedx-platform/openedx/core/djangoapps/content_libraries/tests/test_events.py
Line 595 in eb85705
Testing instructions
Just make sure the tests are passing and the new tests are similar in coverage and effect to the deleted tests. This PR only changes test code and has no effects on the application code itself.
Deadline
ASAP