feat: Drop support for the legacy Grading page.#38418
Draft
irfanuddinahmad wants to merge 5 commits intomasterfrom
Draft
feat: Drop support for the legacy Grading page.#38418irfanuddinahmad wants to merge 5 commits intomasterfrom
irfanuddinahmad wants to merge 5 commits intomasterfrom
Conversation
irfanuddinahmad
force-pushed
the
iahmad/DEPR-36108-grading
branch
from
4d6e343 to
a560b9c
Compare
irfanuddinahmad
changed the title
irfanuddinahmad
force-pushed
the
iahmad/DEPR-36108-grading
branch
2 times, most recently
from
da30635 to
267a7d1
Compare
The legacy Grading page in Studio has been replaced with a new view in the Authoring MFE. This change removes the now unused JS/HTML/Python related to the old page. This work is part of #36108 BREAKING CHANGE: The 'legacy_studio.grading' waffle flag will no longer be respected. The system will behave as if the flag is set to false permanently.
irfanuddinahmad
force-pushed
the
iahmad/DEPR-36108-grading
branch
2 times, most recently
from
a1f2ba6 to
fbb19f7
Compare
irfanuddinahmad
force-pushed
the
iahmad/DEPR-36108-grading
branch
from
fbb19f7 to
502aede
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the legacy grading settings page and its supporting code from the codebase. The grading settings are now handled exclusively by the new grading page, and all references, templates, and JavaScript for the old implementation have been deleted.
Removal of legacy grading settings page:
settings_graders.htmltemplate, which previously rendered the legacy grading settings UI.settings_graders.jsfactory and its dependencies, eliminating the JavaScript logic for the old grading settings page.Backend code cleanup:
course.py, including theuse_new_grading_pagetoggle andget_course_gradingimport.grading_handlerview to always redirect to the new grading page, removing the conditional logic and legacy rendering path.