feat: Drop support for the legacy Advanced Settings page.#38419
Draft
irfanuddinahmad wants to merge 1 commit intomasterfrom
Draft
feat: Drop support for the legacy Advanced Settings page.#38419irfanuddinahmad wants to merge 1 commit intomasterfrom
irfanuddinahmad wants to merge 1 commit intomasterfrom
Conversation
The legacy Advanced Settings page in Studio has been replaced with a new view in the Authoring MFE. This change removes the now unused JS/HTML/Python related to the old page. This work is part of #36108 BREAKING CHANGE: The 'legacy_studio.advanced_settings' waffle flag will no longer be respected. The system will behave as if the flag is set to false permanently.
irfanuddinahmad
force-pushed
the
iahmad/DEPR-36108-advanced-settings
branch
from
f442d3e to
07cb3ab
Compare
irfanuddinahmad
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the legacy "Advanced Settings" page and its related backend and frontend code, fully transitioning the advanced settings experience to the new Micro-Frontend (MFE) implementation. The main changes include deleting the old Django template and JavaScript factory, and cleaning up references and logic associated with the legacy page in the Django view.
Key removals and cleanups:
Frontend removal:
settings_advanced.js) and the corresponding Django template (settings_advanced.html). [1] [2]Backend cleanup:
advanced_settings_handlerview that rendered the old advanced settings page, including publisher/proctoring settings and error handling. Now, requests are redirected to the new MFE-based advanced settings page.use_new_advanced_settings_pageandget_proctored_exam_settings_url. [1] [2] [3]These changes ensure that all users are now directed to the new advanced settings experience and that the codebase is simplified by removing obsolete code.