fix: update modulestore migrator to not publish in draft context#38508
fix: update modulestore migrator to not publish in draft context#38508bradenmacdonald wants to merge 1 commit intoopenedx:masterfrom
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Description
This fixes a few issues:
Issue 1: importing a course or legacy library using modulestore_migrator currently creates a single draft changelog, but many separate publish logs - one for each component or container. It should only create a single publish log per import.
Issue 2:
modulestore_migratoris doing a weird call tosave()the draft change log, which doesn't seem to make any sense, and is expressly forbidden by openedx-core's API conventions.Issue 3: We have considered changing openedx-core so that it doesn't allow publishing entities within a "bulk draft changes" context, which would help ensure the integrity of both our draft and published change logs / data. However,
modulestore_migratorcurrently publishes things within a bulk draft changes context.Testing instructions
Needs some careful thought to know if publishing the entities in this different way is going to cause any issues.
Deadline
None