feat: translate PARAGON_THEME_URLS to frontend-base theme config#38610
Merged
arbrandes merged 1 commit intoopenedx:masterfrom May 7, 2026
Merged
Conversation
brian-smith-tcril
approved these changes
May 7, 2026
Adds a structural translator from the legacy PARAGON_THEME_URLS shape (frontend-platform's env.config.jsx) into the frontend-base SiteConfig `theme` setting served by FrontendSiteConfigView. frontend-base loads Paragon's base CSS via its shell stylesheet, so the runtime `theme` is exclusively a brand-override mechanism. The translator deliberately narrows to `urls.brandOverride` only; bare `url` and `urls.default` would point at Paragon defaults and clobber the bundled CSS, so they are dropped. `defaults` passes through unchanged when at least one URL survives, and is dropped (along with the whole `theme` key) when no URL survives, since `defaults` alone is meaningless without a stylesheet to point at. PARAGON_THEME_URLS is also added to the site-level keys stripped from per-app MFE_CONFIG_OVERRIDES, since `theme` is site-level only in frontend-base. Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
force-pushed
the
arbrandes/shim-paragon-theme-urls
branch
from
be2926f to
11796c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a structural translator from the legacy
PARAGON_THEME_URLSshape (frontend-platform'senv.config.jsx) into the frontend-baseSiteConfig.themesetting served byFrontendSiteConfigView.frontend-base loads Paragon's base CSS via its shell stylesheet, so the runtime
themesetting is exclusively a brand-override mechanism. The translator deliberately narrows tourls.brandOverrideonly. Bareurlandurls.default(which historically pointed at Paragon defaults) are dropped, since translating them would clobber the bundled CSS with potentially stale URLs.defaultspasses through unchanged. Custom brand-only variants whose legacy form was a bareurlare not translated; deployers using those would re-author them in frontend-base directly.PARAGON_THEME_URLSis also added to the set of site-level keys stripped from per-appMFE_CONFIG_OVERRIDES, sincethemeis site-level only in frontend-base. Both translations are factored through a newLEGACY_SITE_LEVEL_KEYSconstant so the rename map and the structural translator stay in sync at the strip site.LLM usage notice
Built with assistance from Claude.