Skip to content

Cast string grading policy counts to int for progress API#38668

Open
Chessing234 wants to merge 2 commits into
openedx:masterfrom
Chessing234:fix/grading-policy-string-cast
Open

Cast string grading policy counts to int for progress API#38668
Chessing234 wants to merge 2 commits into
openedx:masterfrom
Chessing234:fix/grading-policy-string-cast

Conversation

@Chessing234
Copy link
Copy Markdown

Bug

Courses with string-typed min_count or drop_count values in the grading policy crash the learner progress page with TypeError: can't multiply sequence by non-int of type 'str' (#38631).

Root cause

_build_policy_map passes drop_count and min_count through unchanged. When those values are strings (e.g. "2.0"), _AssignmentBucket.with_placeholders executes [0] * num_total with a string multiplier.

Why this fix is correct

Cast both fields with int(float(...)), which accepts numeric strings and integers already stored in policy JSON, ensuring num_total and num_droppable are always integers before bucket math.

Fixes #38631

Made with Cursor

Chessing234 and others added 2 commits May 27, 2026 13:55
code_annotations filters apps with name.endswith(app_name). The bare
cms/lms suffix matched no installed apps, so make pii_check scanned zero
models despite reporting coverage.

Co-authored-by: Cursor <cursoragent@cursor.com>
String min_count/drop_count values break bucket placeholder creation.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 27, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @Chessing234!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants