Cast string grading policy counts to int for progress API#38668
Cast string grading policy counts to int for progress API#38668Chessing234 wants to merge 2 commits into
Conversation
code_annotations filters apps with name.endswith(app_name). The bare cms/lms suffix matched no installed apps, so make pii_check scanned zero models despite reporting coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
String min_count/drop_count values break bucket placeholder creation. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for the pull request, @Chessing234! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Bug
Courses with string-typed
min_countordrop_countvalues in the grading policy crash the learner progress page withTypeError: can't multiply sequence by non-int of type 'str'(#38631).Root cause
_build_policy_mappassesdrop_countandmin_countthrough unchanged. When those values are strings (e.g."2.0"),_AssignmentBucket.with_placeholdersexecutes[0] * num_totalwith a string multiplier.Why this fix is correct
Cast both fields with
int(float(...)), which accepts numeric strings and integers already stored in policy JSON, ensuringnum_totalandnum_droppableare always integers before bucket math.Fixes #38631
Made with Cursor