fix: backport openedx-forum 0.4.1 to teak for thread sort bug#38709
fix: backport openedx-forum 0.4.1 to teak for thread sort bug#38709taimoor-ahmed-1 wants to merge 2 commits into
Conversation
Bumps the `openedx-forum` pin from 0.4.0 to 0.4.1 on `release/teak` to pull in the fix for the "pinned"-NULL sort bug (openedx/forum#270, commit 78b36e4) where discussion threads were not ordering correctly when users selected "recent first" — old threads with NULL `pinned` values floated above newer threads. Reported in: https://discuss.openedx.org/t/discuss-forum-messages-order-not-organized-as-expected-in-teak/18665 Caps openedx-forum at <=0.4.1 in constraints.txt to avoid: * 0.4.2 — drops Python 3.11 support (Teak still supports 3.11) * 0.4.3 — removes the MongoDB backend (Teak deployments may rely on it) The 0.4.0 -> 0.4.1 delta also adds the optional Typesense search backend (additive, off by default), pulling in `typesense==2.0.0` as a new transitive dependency. That pin is added to the compiled requirements files. The constraint should be removed on master / post-Teak release lines. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Thanks for the pull request, @taimoor-ahmed-1! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
openedx-forum 0.4.1 adds the (off-by-default) Typesense search backend, which transitively requires `typesense`. typesense>=2.0.0 requires httpx>=0.28.1, but pact-python==2.0.1 — a transitive test dependency already pinned on release/teak — requires httpx==0.23.3. That is an unresolvable pip conflict and causes CI's "Compile requirements" step to fail with ResolutionImpossible. typesense==1.3.0 only requires `requests`+`typing-extensions` (both already present on teak) and is sufficient since the Typesense backend is off by default on Teak; the active search backends are Meilisearch and Elasticsearch which do not depend on the typesense client. Adds `typesense<2.0.0` to requirements/constraints.txt with an explanatory comment and regenerates the compiled requirements files via `pip-compile --upgrade-package openedx-forum`. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
3 participants
Summary
Bumps the
openedx-forumpin from 0.4.0 to 0.4.1 onrelease/teakto backport the fix for the discussion-forum "pinned"-NULL sort bug.pinnedcolumn onCommentThreadcould beNULL(in addition to0/1), and SQL's NULL ordering scrambled theORDER BY -pinned, last_activity_atresult.78b36e4) — setsdefault=Falseon thepinnedmodel field and backfills existingNULLrows via migration0005_alter_commentthread_pinned. Released as forum0.4.1on 2026-03-30.Why cap at 0.4.1?
A constraint
openedx-forum<=0.4.1is added torequirements/constraints.txtto keep the Teak line on the safe side of two breaking releases:The constraint should be dropped on
master/ post-Teak release lines.Files changed
requirements/constraints.txt— adds theopenedx-forum<=0.4.1cap with an explanatory comment block.requirements/edx/{base,development,testing,doc}.txt— bumps the pinnedopenedx-forumline from 0.4.0 → 0.4.1, and adds the new transitivetypesense==2.0.0dep that 0.4.1 pulls in.If preferred, maintainers can re-run
make upgrade-package package=openedx-forumto regenerate the compiled files canonically — the resulting diff should match this PR.Test plan
openedx-forum==0.4.1no longer shows old threads at the top of "recent first" sort.0005_alter_commentthread_pinnedapplies cleanly andpinnedcolumn has noNULLrows aftermanage.py lms migrate.make upgrade-package package=openedx-forumproduces no further changes.🤖 Generated with Claude Code