Skip to content

Fix for Twitter compatibility#9313

Merged
bradenmacdonald merged 1 commit intoopenedx:masterfrom
open-craft:twitter-tpa
Aug 27, 2015
Merged

Fix for Twitter compatibility#9313
bradenmacdonald merged 1 commit intoopenedx:masterfrom
open-craft:twitter-tpa

Conversation

@bradenmacdonald
Copy link
Copy Markdown
Contributor

Description: When I implemented #8155 I only checked support for OAuth2. However some Open edX users are using login backends such as Twitter that are based on OAuth1.

This PR tweaks the new configuration system so it is compatible with both OAuth1 and OAuth2 providers.

I manually tested this fix and confirmed it works and allows Twitter login.

Sandbox: http://pr9313.sandbox.opencraft.com/login (you can test it out if you have a Twitter account)

Setup Instructions: https://groups.google.com/d/msg/openedx-ops/RerASgJQACM/UMFR_QfdHwAJ

Reviewers: @Kelketek and TBD

@antoviaque
Copy link
Copy Markdown
Contributor

FYI @nedbat . Also @bradenmacdonald posted on the ML before signing off, but I don't see his email in the thread at https://groups.google.com/forum/#!topic/openedx-ops/RerASgJQACM (maybe stuck in the moderation queue?). Edit: It appeared in the meantime. Thanks if someone unstuck it : )

@nedbat
Copy link
Copy Markdown
Contributor

nedbat commented Aug 14, 2015

Yeah, sorry, and I responded with a link before noticing that his message was in the moderation queue. Thanks for being so diligent, @bradenmacdonald!

@bradenmacdonald
Copy link
Copy Markdown
Contributor Author

@Kelketek This is ready for your review.

@Kelketek
Copy link
Copy Markdown
Contributor

👍

@bradenmacdonald
Copy link
Copy Markdown
Contributor Author

@nedbat @cpennington Is either of you available to review this SSO PR? (If not I'll ask Sarina to schedule something. There's no deadline for this.)

@cpennington
Copy link
Copy Markdown
Contributor

Looks like a nice simple change. 👍

@bradenmacdonald
Copy link
Copy Markdown
Contributor Author

Rebased and squashed; merging now. Thanks for your help with this @nedbat, @Kelketek and @cpennington !

bradenmacdonald added a commit that referenced this pull request Aug 27, 2015
@bradenmacdonald bradenmacdonald merged commit ba1b842 into openedx:master Aug 27, 2015
@bradenmacdonald bradenmacdonald deleted the twitter-tpa branch August 27, 2015 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants