Fix for Twitter compatibility#9313
Conversation
|
FYI @nedbat . Also @bradenmacdonald posted on the ML before signing off, but I don't see his email in the thread at https://groups.google.com/forum/#!topic/openedx-ops/RerASgJQACM (maybe stuck in the moderation queue?). Edit: It appeared in the meantime. Thanks if someone unstuck it : ) |
|
Yeah, sorry, and I responded with a link before noticing that his message was in the moderation queue. Thanks for being so diligent, @bradenmacdonald! |
d05c0a7 to
6e06bc5
Compare
6e06bc5 to
42ac3e4
Compare
|
@Kelketek This is ready for your review. |
|
👍 |
|
@nedbat @cpennington Is either of you available to review this SSO PR? (If not I'll ask Sarina to schedule something. There's no deadline for this.) |
|
Looks like a nice simple change. 👍 |
42ac3e4 to
586c237
Compare
|
Rebased and squashed; merging now. Thanks for your help with this @nedbat, @Kelketek and @cpennington ! |
Fix for Twitter compatibility
Description: When I implemented #8155 I only checked support for OAuth2. However some Open edX users are using login backends such as Twitter that are based on OAuth1.
This PR tweaks the new configuration system so it is compatible with both OAuth1 and OAuth2 providers.
I manually tested this fix and confirmed it works and allows Twitter login.
Sandbox: http://pr9313.sandbox.opencraft.com/login (you can test it out if you have a Twitter account)
Setup Instructions: https://groups.google.com/d/msg/openedx-ops/RerASgJQACM/UMFR_QfdHwAJ
Reviewers: @Kelketek and TBD