[BD-46] fix: remove props spreading in DataTable components#2752
Closed
viktorrusakov wants to merge 1 commit intomasterfrom
Closed
[BD-46] fix: remove props spreading in DataTable components#2752viktorrusakov wants to merge 1 commit intomasterfrom
DataTable components#2752viktorrusakov wants to merge 1 commit intomasterfrom
Conversation
|
Thanks for the pull request, @viktorrusakov! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2752 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 235 235
Lines 4237 4237
Branches 1029 1029
=======================================
Hits 3933 3933
Misses 300 300
Partials 4 4
☔ View full report in Codecov by Sentry. |
|
@viktorrusakov Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes redundant props spreading in
DataTablesubcomponents that cause a lot of console errors during development, more details in #2751Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
exampleapp?wittjeffandadamstankiewiczas reviewers on this PR.Post-merge Checklist