-
Notifications
You must be signed in to change notification settings - Fork 91
feat: adding classname prop to sheet component #3855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding classname prop to sheet component #3855
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx-v23 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.x #3855 +/- ##
================================================
+ Coverage 94.30% 94.33% +0.03%
================================================
Files 242 242
Lines 4229 4235 +6
Branches 960 959 -1
================================================
+ Hits 3988 3995 +7
+ Misses 237 236 -1
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cada56d to
056df41
Compare
056df41 to
8792886
Compare
PKulkoRaccoonGang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it’s a good idea to allow passing custom class names both for the wrapper and for the component itself 👍
- sheetClassName: to specify custom classes to the sheet element
- className: to specify custom classes to the base/container element
I’d like to suggest reconsidering the naming here. It might be clearer for consumers if we use containerClassName for the base/container element, and simply className for the sheet element.
This is just a suggestion, I’d be interested to hear your thoughts.
|
@jacobo-dominguez-wgu did you see @PKulkoRaccoonGang's note?
|
|
@brian-smith-tcril, @PKulkoRaccoonGang I came up with these classNames names based on some similarities on the |
|
🎉 This PR is included in version 23.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Adding classname props to Sheet component, the props added are:
Also created the unit tests to support these additions.
It closes #3750
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
exampleapp?Post-merge Checklist