feat: Add taxonomy and tag event sinks #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmtcril
force-pushed
the
bmtcril/add_tags_and_taxonomies
branch
2 times, most recently
from
b66cf82 to
aa8217a
Compare
Ian2012
reviewed
Sep 19, 2024
Ian2012
approved these changes
Sep 19, 2024
Contributor
Author
|
@saraburns1 @Ian2012 If anyone wants to take another review of the last commit it's there, otherwise I'll merge this in a couple of hours. |
Ian2012
reviewed
Sep 23, 2024
saraburns1
reviewed
Sep 23, 2024
CSV doesn't work yet
Also linting cleanups.
The integer parent id was hard coded to 0 previously, but it seems that we're using it, so now it is included.
Fix typo, default tag parent_id to 0 instead of null.
bmtcril
force-pushed
the
bmtcril/add_tags_and_taxonomies
branch
from
05b95f9 to
8e7c8e3
Compare
saraburns1
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tag, taxonomy, and object tag test data population to the script.