Skip to content

Video block karma webpack tests#189

Merged
salman2013 merged 3 commits intomainfrom
salman/video-block-karma-tests
Mar 11, 2026
Merged

Video block karma webpack tests#189
salman2013 merged 3 commits intomainfrom
salman/video-block-karma-tests

Conversation

@salman2013
Copy link
Copy Markdown
Contributor

@salman2013 salman2013 commented Mar 6, 2026

Description:
Add Karma webpack JS test for extracted video block.

How to test locally

npm install
npm run build
npm run test

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Mar 6, 2026
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Mar 6, 2026

Thanks for the pull request, @salman2013!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Comment thread xblocks_contrib/video/tests/js/video_context_menu_spec.js Dismissed
@salman2013 salman2013 marked this pull request as ready for review March 6, 2026 12:11
@salman2013 salman2013 requested review from farhan and irtazaakram and removed request for farhan March 6, 2026 12:36
@salman2013 salman2013 mentioned this pull request Mar 6, 2026
@salman2013 salman2013 removed the request for review from irtazaakram March 6, 2026 12:46
@salman2013 salman2013 marked this pull request as draft March 6, 2026 12:51
@salman2013 salman2013 force-pushed the salman/video-block-karma-tests branch from c0383d7 to 5bf2208 Compare March 6, 2026 18:27
@salman2013 salman2013 marked this pull request as ready for review March 6, 2026 18:31
@salman2013 salman2013 requested review from farhan and irtazaakram March 6, 2026 18:31
Copy link
Copy Markdown
Contributor

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good to me.
Create the story and link.

Comment thread xblocks_contrib/video/tests/js/video_player_spec.js Outdated
Comment thread xblocks_contrib/video/tests/js/video_poster_spec.js Outdated
Copy link
Copy Markdown
Contributor

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salman2013 salman2013 merged commit 69c1563 into main Mar 11, 2026
17 checks passed
@salman2013 salman2013 deleted the salman/video-block-karma-tests branch March 11, 2026 11:43
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants