Skip to content

Remove XModuleMixin legacy attibs from wordcloud, video block, lti block#204

Merged
farhan merged 2 commits intomainfrom
farhan/remove-legacy-attribs
Mar 30, 2026
Merged

Remove XModuleMixin legacy attibs from wordcloud, video block, lti block#204
farhan merged 2 commits intomainfrom
farhan/remove-legacy-attribs

Conversation

@farhan
Copy link
Copy Markdown
Contributor

@farhan farhan commented Mar 25, 2026

Tickets covered in the PR:

#205, #206, #207

Extracted blocks enabled [Sandbox created]

Relevant edx-platform test cases fixing PR: openedx/openedx-platform#38220

Refactoring stuff done in this PR:

Some refactoring work has been done in this commit to clean the code
d4920b3

@farhan farhan changed the title chore: remove XModuleMixin legacy attibutes from wordcloud, video block Remove XModuleMixin legacy attibutes from wordcloud, video block Mar 25, 2026
@farhan farhan changed the title Remove XModuleMixin legacy attibutes from wordcloud, video block Remove XModuleMixin legacy attibs from wordcloud, video block Mar 25, 2026
@farhan farhan force-pushed the farhan/remove-legacy-attribs branch from e0dd2b7 to 7d33317 Compare March 25, 2026 09:33
@farhan farhan force-pushed the farhan/remove-legacy-attribs branch from 7e5c97e to 8fabc13 Compare March 25, 2026 15:35
@farhan farhan force-pushed the farhan/remove-legacy-attribs branch 4 times, most recently from 1d3fed4 to 29113a6 Compare March 26, 2026 11:26
@farhan farhan requested a review from kdmccormick March 27, 2026 07:48
@farhan farhan force-pushed the farhan/remove-legacy-attribs branch from ecb8ea4 to d4920b3 Compare March 27, 2026 07:55
farhan added a commit to openedx/openedx-platform that referenced this pull request Mar 27, 2026
@farhan farhan changed the title Remove XModuleMixin legacy attibs from wordcloud, video block Remove XModuleMixin legacy attibs from wordcloud, video block, lti block Mar 27, 2026
Copy link
Copy Markdown
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@farhan farhan merged commit 917a512 into main Mar 30, 2026
12 of 13 checks passed
@farhan farhan deleted the farhan/remove-legacy-attribs branch March 30, 2026 10:45
farhan added a commit to openedx/openedx-platform that referenced this pull request Mar 31, 2026
Test cases needs to be fixed after merging of following PR in xblocks-contrib
openedx/xblocks-core#204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants