Skip to content

Adds imagemodal, submit-and-comparexblocks#12

Open
farhan wants to merge 4 commits intomainfrom
farhan/add-blocks
Open

Adds imagemodal, submit-and-comparexblocks#12
farhan wants to merge 4 commits intomainfrom
farhan/add-blocks

Conversation

@farhan
Copy link
Copy Markdown

@farhan farhan commented Apr 3, 2026

Tickets:

#8, #11

Details:

Adds imagemodal, submit-and-compare

Deprecation PR's in the repositories:

openedx/xblock-submit-and-compare#250
openedx/xblock-image-modal#260

Testing notes:

Install the xblocks-extras and xblocks should work fine.

Screen shots:

>>> Studio

Submit & Compare
screencapture-apps-local-openedx-io-2001-authoring-course-course-v1-axim-4-4-container-block-v1-axim-4-4-type-vertical-block-1574c283af6c43eea89b977eb9797327-block-v1-axim-4-4-type-sequential-block-8da30fa0afac4746943dd8a9a5514c3f-2026-04-0

Image Modal
screencapture-apps-local-openedx-io-2001-authoring-course-course-v1-axim-4-4-container-block-v1-axim-4-4-type-vertical-block-84a7f48d71de40918b0246c2dec5d6ef-block-v1-axim-4-4-type-sequential-block-8da30fa0afac4746943dd8a9a5514c3f-2026-04-0


>>> LMS

Submit & Compare
screencapture-apps-local-openedx-io-2000-learning-course-course-v1-axim-4-4-block-v1-axim-4-4-type-sequential-block-8da30fa0afac4746943dd8a9a5514c3f-block-v1-axim-4-4-type-vertical-block-1574c283af6c43eea89b977eb9797327-2026-04-07-11_09_59

Image Modal
screencapture-apps-local-openedx-io-2000-learning-course-course-v1-axim-4-4-block-v1-axim-4-4-type-sequential-block-8da30fa0afac4746943dd8a9a5514c3f-block-v1-axim-4-4-type-vertical-block-84a7f48d71de40918b0246c2dec5d6ef-2026-04-07-11_10_19

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.33%. Comparing base (3ae5db1) to head (67f30a4).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           irtaza/add-audio-xblock      #12   +/-   ##
========================================================
  Coverage                    83.33%   83.33%           
========================================================
  Files                            1        1           
  Lines                            6        6           
  Branches                         1        1           
========================================================
  Hits                             5        5           
  Partials                         1        1           
Flag Coverage Δ
unittests 83.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@farhan farhan force-pushed the farhan/add-blocks branch from 6533de7 to 67f30a4 Compare April 3, 2026 08:02
@farhan farhan marked this pull request as draft April 3, 2026 08:12
@farhan farhan force-pushed the farhan/add-blocks branch from 63f9ba7 to 952343c Compare April 3, 2026 11:17
Base automatically changed from irtaza/add-audio-xblock to main April 6, 2026 13:30
@farhan farhan force-pushed the farhan/add-blocks branch from 78d6249 to 997cd25 Compare April 7, 2026 05:34
@farhan farhan force-pushed the farhan/add-blocks branch from 997cd25 to 4d231e2 Compare April 7, 2026 06:05
@farhan farhan marked this pull request as ready for review April 7, 2026 06:19
@farhan farhan mentioned this pull request Apr 7, 2026
@salman2013
Copy link
Copy Markdown

@farhan As per weekly meeting decision, we do not have to move schoolyourself xblock into xblocks-extra so please remove it in this PR.

@farhan farhan changed the title Adds imagemodal, submit-and-compare & schoolyourself xblocks Adds imagemodal, submit-and-comparexblocks Apr 9, 2026
@farhan
Copy link
Copy Markdown
Author

farhan commented Apr 9, 2026

@farhan As per weekly meeting decision, we do not have to move schoolyourself xblock into xblocks-extra so please remove it in this PR.

@salman2013
Done, please continue your review

@salman2013
Copy link
Copy Markdown

@farhan For xblock-submit-and-compare can you confirm about these files if these are needed or not.
https://github.com/openedx/xblock-submit-and-compare/tree/03d348ab6cf07cfaa3b158199d6ed3c6df8d6374/docs/img

Copy link
Copy Markdown

@salman2013 salman2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhan
Copy link
Copy Markdown
Author

farhan commented Apr 9, 2026

@salman2013
Readme files added.
docs folder copied as well.
Ready for next pass.

Relevant deprecation PR's have been created and added in the PR description, please review them as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants