-
Notifications
You must be signed in to change notification settings - Fork 853
refpolicy-targeted: Allowed mount to run with system role #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
29 changes: 29 additions & 0 deletions
29
...x/recipes-security/refpolicy/refpolicy-targeted/0002-Allow-mount-to-run-with-system.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| From aae163bded7e04386707fae5d14909b484a5e222 Mon Sep 17 00:00:00 2001 | ||
| From: Gargi Misra <gmisra@qti.qualcomm.com> | ||
| Date: Fri, 27 Mar 2026 12:00:18 +0530 | ||
| Subject: [PATCH] refpolicy-targeted: Allow mount to run with system role | ||
|
|
||
| type=SELINUX_ERR msg=audit(44.591:158): op=security_compute_sid invalid_context="system_u:system_r:unconfined_mount_t:s0" scontext=system_u:system_r:unconfined_t:s0 tcontext=system_u:object_r:mount_exec_t:s0 tclass=process | ||
|
|
||
| Upstream-Status: Inappropriate [meta-oe specific] | ||
|
|
||
| Signed-off by: Gargi Misra <gmisra@qti.qualcomm.com> | ||
| --- | ||
| policy/modules/system/unconfined.te | 1 + | ||
| 1 file changed, 1 insertion(+) | ||
|
|
||
| diff --git a/policy/modules/system/unconfined.te b/policy/modules/system/unconfined.te | ||
| index 1c98f5e85..26085d7d8 100644 | ||
| --- a/policy/modules/system/unconfined.te | ||
| +++ b/policy/modules/system/unconfined.te | ||
| @@ -39,6 +39,7 @@ logging_send_syslog_msg(unconfined_t) | ||
| logging_run_auditctl(unconfined_t, unconfined_r) | ||
|
|
||
| mount_run_unconfined(unconfined_t, unconfined_r) | ||
| +mount_run_unconfined(unconfined_t, system_r) | ||
|
|
||
| seutil_run_setfiles(unconfined_t, unconfined_r) | ||
| seutil_run_semanage(unconfined_t, unconfined_r) | ||
| -- | ||
| 2.43.0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this meta-oe specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue is observed in the adb shell, which is provided by meta-oe, hence it is meta-oe specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GargiQcom if the change was in recipe or other metadata then it will be meta-oe for sure or if the change was just needed for OE for some reason. Since the patch is changing the original component, we have to answer question if this patch should be submitted to refpolicy-targeted component upstream or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. Since the overall approach is disputed and doesn’t seem suitable for this repo, I’ll close this PR and re-evaluate the change internally before deciding on the right upstream path.