This repository was archived by the owner on May 24, 2022. It is now read-only.
feat: Delete account #528
Merged
feat: Delete account #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelchalon
approved these changes
Jun 5, 2019
Contributor
axelchalon
left a comment
axelchalon
left a comment
There was a problem hiding this comment.
works well & code lgtm!
Tbaut
approved these changes
Jun 5, 2019
Collaborator
Tbaut
left a comment
Tbaut
left a comment
There was a problem hiding this comment.
just a nit.
Works well (also tested with a Signer account)
Co-Authored-By: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Collaborator
|
I'll commit the german translation directly if you're ok. It might not be perfect, but better than nothing. |
Collaborator
Author
|
Sure, it'll be much simpler like this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #448
Unfortunately I didn't add German translations. I can deepl them, but not sure it's the best