Skip to content
This repository was archived by the owner on Apr 22, 2025. It is now read-only.

Member Profiles Closes #586#591

Closed
roryaronson wants to merge 11 commits intoopenfarmcc:masterfrom
roryaronson:member-profiles
Closed

Member Profiles Closes #586#591
roryaronson wants to merge 11 commits intoopenfarmcc:masterfrom
roryaronson:member-profiles

Conversation

@roryaronson
Copy link
Member

This PR includes initial frontend work for 'member profile' pages. This consolidates the 'My Guides', 'My Gardens', and 'Account Settings' pages into one place for the member. It is also the beginnings of how members can interact with each other.

Things that are broken in this PR:

  • Try deleting a Guide. It deletes it successfully but redirects the page to an error
  • The devise/registrations/edit partial doesn't work. Try uncommenting it and you'll see
  • /guides/index isn't there anymore. Should we stub out something for Rails convention sake or should we redirect to the profile page?

Next Steps:

  • Make the new 'Add Garden' button work and remove old confusing foo (lookout on Slack for a mockup of member signup flow)
  • Displaying member badges
  • Allow members to have a favorite_crop in the user_settings and display that Crop's image as their cover photo
  • Allow members to upload a profile photo, and make/select a default one that isn't a barren field
  • Follower/Following/Follow buttons? Explore/cinform what this concept even does and if we/members want such a thing
  • Privacy controls
  • Enable editing of the member profile

screenshot from 2015-04-07 00 35 03

screenshot from 2015-04-07 00 42 10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like #ffffff should only be used in variable declarations; they should be referred to via variable everywhere else.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.38%) to 99.44% when pulling 5623d97 on roryaronson:member-profiles into 2392069 on openfarmcc:master.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax Error: Invalid CSS after "...ne-height: 56px": expected "{", was ";"

@simonv3
Copy link
Member

simonv3 commented Apr 7, 2015

I think instead of "Coming Soon" things we shouldn't mention them.

Actually, there's a couple of things that I wonder about including until we have the functionality - including the header image / profile image.

Commenting them out in the code shouldn't be a problem though, I just feel like we shouldn't push stuff life that users can't actually edit.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.4 should be written without a leading zero as .4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants