This repository was archived by the owner on Apr 22, 2025. It is now read-only.
Member Profiles Closes #586#591
Closed
roryaronson wants to merge 11 commits intoopenfarmcc:masterfrom
Closed
Conversation
There was a problem hiding this comment.
Color literals like #ffffff should only be used in variable declarations; they should be referred to via variable everywhere else.
There was a problem hiding this comment.
Syntax Error: Invalid CSS after "...ne-height: 56px": expected "{", was ";"
Member
|
I think instead of "Coming Soon" things we shouldn't mention them. Actually, there's a couple of things that I wonder about including until we have the functionality - including the header image / profile image. Commenting them out in the code shouldn't be a problem though, I just feel like we shouldn't push stuff life that users can't actually edit. |
There was a problem hiding this comment.
0.4 should be written without a leading zero as .4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes initial frontend work for 'member profile' pages. This consolidates the 'My Guides', 'My Gardens', and 'Account Settings' pages into one place for the member. It is also the beginnings of how members can interact with each other.
Things that are broken in this PR:
devise/registrations/editpartial doesn't work. Try uncommenting it and you'll see/guides/indexisn't there anymore. Should we stub out something for Rails convention sake or should we redirect to the profile page?Next Steps:
favorite_cropin theuser_settingsand display that Crop's image as their cover photo