Conversation
Removed the red border.
| border: 1px solid $alert-color; | ||
| } | ||
|
|
||
| input#search_crop_name.ng-invalid { |
There was a problem hiding this comment.
Avoid using id selectors
Avoid qualifying id selectors with an element.
Selector search_crop_name should be written in lowercase with hyphens
There was a problem hiding this comment.
@Katy310. I think this is a fair comment. I know that I suggested the above selector, but maybe there's a better way to do so? Do you have time to make a fix to your PR?
| border: 1px solid $alert-color; | ||
| } | ||
|
|
||
| input#search_crop_name.ng-invalid { |
There was a problem hiding this comment.
Avoid using id selectors
Avoid qualifying id selectors with an element.
Selector search_crop_name should be written in lowercase with hyphens
There was a problem hiding this comment.
This is still the same issue from before the update :).
| input.ng-invalid { | ||
| input-invalid-notify{ | ||
| border: none; | ||
| } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
|
|
||
| input.ng-invalid { | ||
| input-invalid-notify{ | ||
| border: none; |
There was a problem hiding this comment.
Line should be indented with spaces, not tabs
| } | ||
|
|
||
| input.ng-invalid { | ||
| input-invalid-notify{ |
There was a problem hiding this comment.
Opening curly brace { should be preceded by one space
| border: none; | ||
| } | ||
|
|
||
| .input-invalid-notify.ng-invalid { |
There was a problem hiding this comment.
Does this class exist in the HTML? Maybe you forgot to add it to the commit?
| } | ||
|
|
||
| input.ng-invalid { | ||
| input-invalid-notify { |
There was a problem hiding this comment.
Are you adding a directive called input-invalid-notify? If so, is there a new directive file that should be part of this commit?
| border: 1px solid $alert-color; | ||
| } | ||
|
|
||
| input#search_crop_name.ng-invalid { |
There was a problem hiding this comment.
This is still the same issue from before the update :).
|
This was fixed in #885 |
4 participants
Removed the red border.