This repository was archived by the owner on Apr 22, 2025. It is now read-only.
Updated ID of favorite button to not clash with print button#884
Merged
simonv3 merged 1 commit intoopenfarmcc:masterfrom Dec 20, 2016
broder:update_favorite_id
Merged
Updated ID of favorite button to not clash with print button#884simonv3 merged 1 commit intoopenfarmcc:masterfrom broder:update_favorite_id
simonv3 merged 1 commit intoopenfarmcc:masterfrom
broder:update_favorite_id
Conversation
Member
|
Thanks for the fix @broder! Yeah, this was likely a copy-paste error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Element IDs should be unique.
Another option would be to remove both of the similar IDs as I can't see them being used anywhere.