Skip to content

Conversation

@justincoh
Copy link
Contributor

@justincoh justincoh commented Dec 18, 2024

Description

OpenFGA already rejects tokens which contain base64-invalid characters in its handlers. This PR is an added layer of protection to ensure that an invalid token won't make it to the handling functions at all.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@justincoh justincoh changed the title Add pattern restriction on continuation_tokens fix: add pattern restriction on continuation_token Dec 18, 2024
@justincoh justincoh marked this pull request as ready for review December 18, 2024 21:48
@justincoh justincoh requested a review from a team as a code owner December 18, 2024 21:48
@justincoh justincoh changed the title fix: add pattern restriction on continuation_token chore: add pattern restriction on continuation_token Dec 19, 2024
@justincoh justincoh merged commit 157144d into main Dec 30, 2024
6 checks passed
@justincoh justincoh deleted the fix/continuation-token-restrictions branch December 30, 2024 17:32
aaguiarz pushed a commit that referenced this pull request Jan 13, 2026
* add pattern restriction on continuation_tokens

* update continuation_token regex to be specific to url base64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants