Skip to content

fix: handle empty auth models list in readlatest auth model #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SoulPancake merged 1 commit into from
Dec 4, 2025
Merged

fix: handle empty auth models list in readlatest auth model #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/dev/openfga/sdk/api/client/model/ClientReadAuthorizationModelResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ public static ClientReadAuthorizationModelResponse latestOf(
ClientReadAuthorizationModelResponse clientResponse = new ClientReadAuthorizationModelResponse(
apiResponse.getStatusCode(), apiResponse.getHeaders(), apiResponse.getRawResponse());
ReadAuthorizationModelsResponse response = apiResponse.getData();
clientResponse.setAuthorizationModel(response.getAuthorizationModels().get(0));
List<dev.openfga.sdk.api.model.AuthorizationModel> models = response.getAuthorizationModels();
if (!models.isEmpty()) {
clientResponse.setAuthorizationModel(models.get(0));
}
return clientResponse;
}

Expand Down
17 changes: 17 additions & 0 deletions src/test/java/dev/openfga/sdk/api/client/OpenFgaClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,6 +746,23 @@ public void readLatestAuthorizationModelTest() throws Exception {
assertEquals(DEFAULT_SCHEMA_VERSION, authModel.getSchemaVersion());
}

@Test
public void readLatestAuthorizationModelTest_emptyList() throws Exception {
// Given
String getUrl = String.format(
"%s/stores/%s/authorization-models?page_size=1", FgaConstants.TEST_API_URL, DEFAULT_STORE_ID);
String responseBody = "{\"authorization_models\":[]}";
mockHttpClient.onGet(getUrl).doReturn(200, responseBody);

// When
ClientReadAuthorizationModelResponse response =
fga.readLatestAuthorizationModel().get();

// Then
mockHttpClient.verify().get(getUrl).called(1);
assertNull(response.getAuthorizationModel());
}

@Test
public void readChanges() throws Exception {
// Given
Expand Down
Loading