Skip to content

chore: remove maven publish dependencies for publish-github-packages job#335

Merged
SoulPancake merged 1 commit intomainfrom
chore/remove-maven-publish
Apr 30, 2026
Merged

chore: remove maven publish dependencies for publish-github-packages job#335
SoulPancake merged 1 commit intomainfrom
chore/remove-maven-publish

Conversation

@SoulPancake
Copy link
Copy Markdown
Member

@SoulPancake SoulPancake commented Apr 30, 2026

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Chores
    • Updated package publishing workflow to optimize job dependencies.

Copilot AI review requested due to automatic review settings April 30, 2026 16:55
@SoulPancake SoulPancake requested a review from a team as a code owner April 30, 2026 16:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release workflow to decouple the GitHub Packages publish job from the Maven Central publish job, allowing them to run independently (while still gating on tests and still both required before creating a release draft).

Changes:

  • Remove publish-maven-central from the needs list of the publish-github-packages job.
  • Keep create-release dependent on both publish jobs to preserve the overall release gating.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 769e903e-f4f4-47b1-a49b-eb4242198a39

📥 Commits

Reviewing files that changed from the base of the PR and between 128671c and 38dbe03.

📒 Files selected for processing (1)
  • .github/workflows/main.yaml

Walkthrough

This PR modifies the GitHub Actions workflow to change the dependency chain for the publish-github-packages job, removing its reliance on publish-maven-central and making it depend solely on the test job completing.

Changes

Cohort / File(s) Summary
CI/CD Workflow Configuration
.github/workflows/main.yaml
Removed publish-maven-central from the needs dependency list of the publish-github-packages job, so it now depends only on the test job.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • curfew-marathon
  • rhamzeh
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the maven publish dependency from the publish-github-packages job in the GitHub workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-maven-publish

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.48%. Comparing base (128671c) to head (38dbe03).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #335   +/-   ##
=========================================
  Coverage     38.48%   38.48%           
  Complexity     1268     1268           
=========================================
  Files           198      198           
  Lines          7704     7704           
  Branches        900      900           
=========================================
  Hits           2965     2965           
  Misses         4591     4591           
  Partials        148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SoulPancake SoulPancake added this pull request to the merge queue Apr 30, 2026
Merged via the queue into main with commit f2b848c Apr 30, 2026
31 checks passed
@SoulPancake SoulPancake deleted the chore/remove-maven-publish branch April 30, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants