fix: exclusion weight where type is not in the excluded relation#443
Merged
fix: exclusion weight where type is not in the excluded relation#443
Conversation
For relation A but not B, we need to use a mixed strategy in calculating weight where a type in A will use the max strategy and B will use the enforced type strategy. This is because a type will be connected to the graph if it appears in A as B is not mandatory. However, a type listed in B MUST also appear in A. Otherwise, relation will never exist for such type.
yissellokta
requested changes
Apr 7, 2025
yissellokta
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For relation A but not B, we need to use a mixed strategy in calculating weight where a type in A will use the max strategy and B will use the enforced type strategy. This is because a type can be connected to the graph if it appears only in A as B is not mandatory. However, a type listed in B MUST also appear in A. Otherwise, relation will never exist for such type.
References
Review Checklist
main