fix: go linting issues

[sergiught]

Description

Fixes go linter issues.

References

Review Checklist

• I have clicked on "allow edits by maintainers".
• I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
• The correct base branch is being used, if not main
• I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

• New Features

  • Added a new method for retrieving graph node edges with improved naming conventions.

• Documentation

  • Enhanced documentation clarity and descriptions for API methods throughout the module.

• Tests

  • Improved test assertions, consistency, and quality across the test suite.

• Chores

  • Deprecated previous method name; users should migrate to the new method.

• Style

  • Refined code formatting, organization, and naming conventions.

[Copilot]

Pull request overview

This PR addresses Go linting complaints in the pkg/go/graph package by adjusting import grouping, tightening test assertions/style, and improving comment spelling/punctuation (plus a targeted linter suppression for an existing public API name).

Changes:

• Reordered imports in graph tests to satisfy goimports grouping.
• Refactored test code to satisfy lint/style checks (camelCase locals, require.Equal instead of require.True(x == y), remove stray blank lines).
• Updated comments for spelling/punctuation and added a //nolint on GetEdgesFromNodeId to avoid a breaking rename.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
pkg/go/graph/weighted_graph_userset_test.go	Adjust import grouping to satisfy goimports.
pkg/go/graph/weighted_graph_test.go	Adjust import grouping and remove extra whitespace in tests.
pkg/go/graph/weighted_graph_edge.go	Comment spelling/formatting tweaks in edge type documentation.
pkg/go/graph/weighted_graph_builder_test.go	Rename locals to Go-style camelCase and tighten assertions/whitespace.
pkg/go/graph/weighted_graph.go	Add linter suppression for GetEdgesFromNodeId and update multiple comments for punctuation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 13f821be-dd4c-4fd7-a4b3-2f81b3a4bd0e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

The PR standardizes naming conventions by renaming the GetEdgesFromNodeId method to GetEdgesFromNodeID (using PascalCase for the "ID" abbreviation per Go idioms), with the old method kept as a deprecated forwarding alias. Test code is refactored with improved variable naming (snake_case to camelCase) and more idiomatic assertion patterns. Comments and imports are also updated for clarity and consistency.

Changes

Cohort / File(s)	Summary
Core API Enhancement pkg/go/graph/weighted_graph.go	Added new GetEdgesFromNodeID(nodeID string) public method with idiomatic capitalization; deprecated GetEdgesFromNodeId() as a forwarding alias. Updated doc comment wording for GetNodeWeight and GetEdgeWeight. Minor comment clarity improvements.
Test Updates pkg/go/graph/weighted_graph_builder_test.go, pkg/go/graph/weighted_graph_concurrent_test.go, pkg/go/graph/weighted_graph_test.go	Updated test code to use new GetEdgesFromNodeID method. Refactored local variable names from snake_case to camelCase across multiple test functions. Improved assertion patterns in TestGraphConstructionTupleCycles from boolean comparisons to direct equality checks using require.Equal(). Minor whitespace cleanup and test function rename.
Housekeeping pkg/go/graph/weighted_graph_edge.go, pkg/go/graph/weighted_graph_userset_test.go	Fixed comment spelling ("unnecesary" → "unnecessary") and formatting. Reordered imports for consistency and added blank line separation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

• adriantam
• SoulPancake
• elbuo8

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 11.76% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The PR title 'fix: go linting issues' is vague and does not clearly convey the specific nature of the changes, which include a new public method, deprecation, naming convention updates, and code cleanup.	Consider using a more specific title that reflects the main changes, such as 'refactor: standardize camelCase naming and add GetEdgesFromNodeID method' or 'chore: apply Go linting fixes and code style improvements'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-lint-go

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

pkg/go/graph/weighted_graph_test.go (1)

1218-1354: Consider adding a compatibility test for deprecated GetEdgesFromNodeId.

While deprecated, it remains exported; a small forwarding test would lock backward compatibility until removal.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@pkg/go/graph/weighted_graph_test.go` around lines 1218 - 1354, Add a small
compatibility test that calls the deprecated function GetEdgesFromNodeId and
verifies it forwards to GetEdgesFromNodeID by creating a graph (use
NewWeightedAuthorizationModelGraph), adding a node and an edge via
AddNode/AddEdge, then calling both GetEdgesFromNodeID("some-node") and
GetEdgesFromNodeId("some-node") and asserting the returned found flag and edges
are equal (e.g., same length and same to.uniqueLabel/edgeType); include this
test alongside the existing TestGetEdgesFromNodeID cases to lock backward
compatibility.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@pkg/go/graph/weighted_graph_test.go`:
- Around line 1218-1354: Add a small compatibility test that calls the
deprecated function GetEdgesFromNodeId and verifies it forwards to
GetEdgesFromNodeID by creating a graph (use NewWeightedAuthorizationModelGraph),
adding a node and an edge via AddNode/AddEdge, then calling both
GetEdgesFromNodeID("some-node") and GetEdgesFromNodeId("some-node") and
asserting the returned found flag and edges are equal (e.g., same length and
same to.uniqueLabel/edgeType); include this test alongside the existing
TestGetEdgesFromNodeID cases to lock backward compatibility.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 796c3a2d-f21d-44e1-8f1a-4606573bfe4f

📥 Commits

Reviewing files that changed from the base of the PR and between 2c54451 and b022975.

📒 Files selected for processing (6)

• pkg/go/graph/weighted_graph.go
• pkg/go/graph/weighted_graph_builder_test.go
• pkg/go/graph/weighted_graph_concurrent_test.go
• pkg/go/graph/weighted_graph_edge.go
• pkg/go/graph/weighted_graph_test.go
• pkg/go/graph/weighted_graph_userset_test.go

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.