feat: Add type restrictions to JSON syntax#7
Merged
Conversation
rhamzeh
force-pushed
the
feat/add-type-restrictions-to-json-syntax
branch
3 times, most recently
from
d2f0cd3 to
1f56665
Compare
adriantam
requested changes
Sep 8, 2022
rhamzeh
force-pushed
the
feat/add-type-restrictions-to-json-syntax
branch
from
1f56665 to
0e2c2dc
Compare
miparnisari
reviewed
Sep 8, 2022
rhamzeh
force-pushed
the
feat/add-type-restrictions-to-json-syntax
branch
5 times, most recently
from
1564ab2 to
bca4aa3
Compare
adriantam
approved these changes
Sep 9, 2022
rhamzeh
force-pushed
the
feat/add-type-restrictions-to-json-syntax
branch
from
bca4aa3 to
2a0cca7
Compare
rhamzeh
force-pushed
the
feat/add-type-restrictions-to-json-syntax
branch
from
2a0cca7 to
0dd0c37
Compare
rhamzeh
force-pushed
the
feat/add-type-restrictions-to-json-syntax
branch
from
d46006b to
b719b5a
Compare
miparnisari
reviewed
Sep 9, 2022
miparnisari
reviewed
Sep 9, 2022
miparnisari
reviewed
Sep 9, 2022
miparnisari
reviewed
Sep 9, 2022
miparnisari
reviewed
Sep 9, 2022
miparnisari
reviewed
Sep 9, 2022
craigpastro
reviewed
Sep 10, 2022
adriantam
requested changes
Sep 12, 2022
adriantam
requested changes
Sep 12, 2022
miparnisari
approved these changes
Sep 12, 2022
rhamzeh
force-pushed
the
feat/add-type-restrictions-to-json-syntax
branch
from
abfa9ca to
bd95762
Compare
jon-whit
reviewed
Sep 13, 2022
Member
Author
@jon-whit can you elaborate please? This is definitely mentioned in the RFC |
4 tasks
jon-whit
reviewed
Sep 13, 2022
jon-whit
reviewed
Sep 13, 2022
jon-whit
reviewed
Sep 13, 2022
jon-whit
approved these changes
Sep 13, 2022
We are retaining our current implemetation where `*` is allowed, and it will mean all users that can be related, are related. A later RFC can re-introduce a restriction on `*` if needed.
miparnisari
reviewed
Sep 13, 2022
adriantam
approved these changes
Sep 29, 2022
4 tasks
matthewpereira
changed the title
jon-whit
suggested changes
Nov 28, 2022
Contributor
jon-whit
left a comment
jon-whit
left a comment
There was a problem hiding this comment.
This RFC needs to be updated to take into account the structure of the existing API changes, namely https://github.com/openfga/api/blob/main/openfga/v1/authzmodel.proto#L70-L80
jon-whit
approved these changes
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This RFC introduces support for type restrictions on relations. This enables restricting what types of users can be assigned to specific relations.
Rendered Version
Click here to view the RFC as a rendered preview.
References
See #8 for additional DSL syntax changes.
Review Checklist
main