1. More precise preloader for html5; 2. Fix font preloading in Safari.#866
Merged
jgranick merged 1 commit intoopenfl:developfrom Dec 20, 2016
restorer:more-precise-preloader
Merged
1. More precise preloader for html5; 2. Fix font preloading in Safari.#866jgranick merged 1 commit intoopenfl:developfrom restorer:more-precise-preloader
jgranick merged 1 commit intoopenfl:developfrom
restorer:more-precise-preloader
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More precise preloader for html5
In latest OpenFL / Lime version preloader din't work as earlier. This PR tries to fix it.
Additionally it adds trace of error, because without it is very difficult to guess why game is not loading (usually this is related because howler can't load .wav or .ogg sound; interestingly, it was working earlier with soundjs, but this is another story...)
Fix font preloading in Safari
It seems that Safari reports that font loaded while font IS NOT actually loaded. There are 2 identical
TextView's, first is added immediately, second after some timeout:This is reproduced with last OpenFL / Lime version, this IS NOT related to font preloading issue fixed in 4e8bc03. This happens only in Safari.
Demo: http://pub.zame-dev.org/openfl-safari-font-preloader/canvas/
Full source: http://pub.zame-dev.org/openfl-safari-font-preloader/project.zip