Skip to content

Prepare flag evaluation#17

Merged
zhouzhuojie merged 1 commit into
masterfrom
zz/evaluation-cache
Oct 9, 2017
Merged

Prepare flag evaluation#17
zhouzhuojie merged 1 commit into
masterfrom
zz/evaluation-cache

Conversation

@zhouzhuojie
Copy link
Copy Markdown
Collaborator

Prepare the flag evaluation.

  • Flag now will preload with the evaluation context
  • Browser route will use hash mode instead of history so that we can deep link.

@zhouzhuojie zhouzhuojie requested a review from lucidrains October 9, 2017 22:56

export default new Router({
mode: 'history',
mode: 'hash',
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucidrains this is just for deep links, for example, in production mode, the history mode will return 404 because it tried to use server side route first.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oo ok

@zhouzhuojie zhouzhuojie merged commit 9c2b088 into master Oct 9, 2017
@zhouzhuojie zhouzhuojie deleted the zz/evaluation-cache branch October 9, 2017 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants