Add UI env for entity types override#175
Merged
Merged
Conversation
michberr
reviewed
Oct 8, 2018
| return arr | ||
| } | ||
|
|
||
| if (process.env.FLAGR_UI_POSSIBLE_ENTITY_TYPES) { |
Collaborator
Author
There was a problem hiding this comment.
It's a bit different, I have to use process.env.FLAGR_UI_POSSIBLE_ENTITY_TYPES here, and also it also needs to be registered in browser/flagr-ui/config. What the compiler does is to do a string interpolation by using the env variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
FLAGR_UI_POSSIBLE_ENTITY_TYPESas build arg for UI, by default it'snull, which means it doesn't imply any restrictions.Motivation and Context
To limit the choices and normalize entity types for better data analytics
How Has This Been Tested?
Tested locally and with docker build-arg
Types of changes