Don't require fields on the evalResult response object#238
Closed
erithmetic wants to merge 2 commits into
Closed
Conversation
Ultimately, it's up to the consumer app to decide what it requires from the server response. This caused an issue under the following circumstance: * A flag did not exist in flagr * The consumer requested a flag by only specifying `:flag_key` * Flagr returned a 200 response with `:flag_id` omitted * The ruby code generated by swagger raised an `ArgumentError` because the response from the server was missing `:flag_id`
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
=======================================
Coverage 83.69% 83.69%
=======================================
Files 25 25
Lines 1441 1441
=======================================
Hits 1206 1206
Misses 177 177
Partials 58 58Continue to review full report at Codecov.
|
Collaborator
|
It requires changes more than just swagger yaml changes. Can you |
Collaborator
|
It may be tricky to fix some tests, thus I created a new PR here #239 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caused an issue under the following circumstance:
:flag_key:flag_idomittedArgumentErrorbecause the response from the server was missing:flag_idUltimately, it's up to the consumer app anyway to decide what it requires from the server response, not the HTTP interface library.