Fix lint and make vendor#249
Merged
Merged
Conversation
zhouzhuojie
commented
Apr 19, 2019
| // NewKinesisRecorder creates a new Kinesis recorder | ||
| var NewKinesisRecorder = func() DataRecorder { | ||
| client := kinesis.New(session.New(aws.NewConfig())) | ||
| se, err := session.NewSession(aws.NewConfig()) |
Collaborator
Author
There was a problem hiding this comment.
static check from golangci-lint caught this, session.New is deprecated. We should use session.NewSession
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
=========================================
- Coverage 82.27% 82.18% -0.1%
=========================================
Files 26 26
Lines 1518 1521 +3
=========================================
+ Hits 1249 1250 +1
- Misses 202 203 +1
- Partials 67 68 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.