Skip to content

fix: Padding#398

Merged
rteyssandier merged 1 commit intomainfrom
fix/padding
Nov 19, 2025
Merged

fix: Padding#398
rteyssandier merged 1 commit intomainfrom
fix/padding

Conversation

@rteyssandier
Copy link
Copy Markdown
Contributor

No description provided.

@rteyssandier rteyssandier self-assigned this Nov 19, 2025
@rteyssandier rteyssandier enabled auto-merge (squash) November 19, 2025 08:51
@rteyssandier rteyssandier added the bug Something isn't working label Nov 19, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the FloconFeature composable by removing the contentPadding parameter. This simplifies the component's API and delegates the responsibility of applying padding to the caller, which is a good design practice that increases flexibility. The change in NetworkScreen.kt correctly adapts to this new API. Overall, this is a good cleanup that addresses a TODO and improves code quality.

@rteyssandier
Copy link
Copy Markdown
Contributor Author

@gemini-code-assist review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the FloconFeature component by removing the contentPadding parameter, which is a good improvement. This change makes the component more flexible and aligns with Jetpack Compose best practices by allowing callers to control padding via modifiers. The related changes in NetworkScreen.kt and the removal of unused imports are correct and complete the refactoring. Overall, this is a clean and beneficial code improvement.

@rteyssandier rteyssandier merged commit 03024a0 into main Nov 19, 2025
@rteyssandier rteyssandier deleted the fix/padding branch November 19, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants