Skip to content

feat: [NETWORK] import from csv#403

Merged
florent37 merged 7 commits intomainfrom
feat-import-csv
Nov 26, 2025
Merged

feat: [NETWORK] import from csv#403
florent37 merged 7 commits intomainfrom
feat-import-csv

Conversation

@florent37
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @florent37, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request lays the groundwork for a new feature allowing users to import network call data from CSV files. It establishes the necessary actions, UI components, and core domain logic for file handling and data parsing, setting the stage for the complete implementation of the import functionality.

Highlights

  • New 'Import From CSV' Feature: Introduced the foundational elements for importing network call data from CSV files, including a new action, a ViewModel handler, and a UI menu item.
  • CSV Import Logic: Added a new ImportNetworkCallsFromCsvUseCase responsible for displaying a file dialog, reading and parsing CSV content, and converting it into FloconNetworkCallDomainModel objects for storage.
  • UI Integration: A new 'Import From CSV' option has been added to the network screen's dropdown menu, utilizing an upload icon.
  • Placeholder Implementation: The onImportFromCsv function in the NetworkViewModel is currently an empty placeholder, indicating that the full integration of the import logic is yet to be completed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the functionality to import network calls from a CSV file. The changes span the UI, ViewModel, and domain layers. My review has identified a few critical issues that need to be addressed, including a bug where the import button triggers an export action, and a compilation error in the new use case. There are also some architectural concerns, such as including UI-specific code in the domain layer. Additionally, the feature is not fully implemented, with several TODOs and an empty handler function. I've provided detailed comments and suggestions to help resolve these issues.

@florent37 florent37 marked this pull request as draft November 21, 2025 10:42
@florent37 florent37 marked this pull request as ready for review November 26, 2025 16:53
@florent37 florent37 merged commit 7974b0a into main Nov 26, 2025
@florent37 florent37 deleted the feat-import-csv branch November 26, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant