Skip to content

feat: [NETWORK] replay#409

Merged
florent37 merged 3 commits intomainfrom
feat-replay
Nov 28, 2025
Merged

feat: [NETWORK] replay#409
florent37 merged 3 commits intomainfrom
feat-replay

Conversation

@florent37
Copy link
Copy Markdown
Contributor

@florent37 florent37 commented Nov 28, 2025

#89

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @florent37, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a new "replay" feature for network calls, allowing users to re-execute past requests. This functionality is integrated across the application, from the database schema which now tracks replayed calls, through the data and domain layers responsible for executing and managing these requests, to the user interface where users can initiate replays and see their results. The changes aim to provide a powerful tool for debugging and testing network interactions.

Highlights

  • Network Call Replay Feature: Introduced the ability to replay previous network requests, enhancing debugging and testing capabilities.
  • Database Schema Update: The FloconNetworkCallEntity now includes an isReplayed flag to track replayed requests, and the database schema hash has been updated.
  • UI Integration: A "Replay" option has been added to the contextual menu for network items, and replayed calls are visually distinguished in the UI with a specific background color.
  • Data Layer Implementation: New NetworkReplayDataSource and its implementation using Ktor HttpClient handle the actual execution of replayed requests, capturing new response details.
  • Domain Layer Logic: A ReplayNetworkCallUseCase orchestrates the replay process, fetching the original request and persisting the new replayed call.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@florent37 florent37 self-assigned this Nov 28, 2025
@florent37 florent37 merged commit 0e61239 into main Nov 28, 2025
@florent37 florent37 deleted the feat-replay branch November 28, 2025 14:48
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a network call replay feature, which is a great addition. The changes span across the database schema, data layer, and UI, and are generally well-implemented. I've identified a few areas for improvement, primarily within the new NetworkReplayDataSourceImpl, concerning hardcoded values and dependency management. There's also a minor code duplication issue in the NetworkViewModel. Addressing these points will enhance the robustness and maintainability of this new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant