fix: Panel db

[rteyssandier]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @rteyssandier, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the display of database row details by integrating it into the application's navigation system. Instead of rendering a detail panel directly within the DatabaseResultView, a new dedicated navigation route and composable (DatabaseDetails) have been introduced. This change centralizes the handling of detail views, allowing for consistent panel behavior (e.g., pinnable, closable) across the application and improving the overall navigation structure.

Highlights

• Navigation Refactor for Database Details: Introduced a new DatabaseRoutes.Detail route to handle the display of individual database row details, allowing for a more structured approach to presenting information.
• Dedicated Detail View Component: A new DatabaseDetails composable was created to serve as the entry point for rendering the detailed view of a database row.
• Panel Integration via Navigation: The detail view is now presented within a panel using the PanelSceneStrategy through the navigation system, replacing the previous inline FloconPanel implementation in DatabaseResultView.
• Serialization for Data Models: DetailResultItem and DatabaseRowUiModel are now marked as Serializable to support their use as navigation arguments.
• Immutability for UI State: DatabasesStateUiModel is annotated with @Immutable to provide a hint to the Compose compiler for potential performance optimizations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the database result detail view from a local panel composable to a navigation-based panel. This is achieved by introducing a new DatabaseRoutes.Detail route and triggering navigation to it upon item selection. The changes are logical and well-structured. My main feedback is regarding code duplication and the use of the Service Locator anti-pattern for navigation within a composable. I've left a comment with suggestions to refactor this for better maintainability and testability.

[gemini-code-assist]

This logic to create a DetailResultItem and navigate is duplicated in three places: here for Key.DirectionUp, for Key.DirectionDown (lines 138-146), and in the onItemSelected callback (lines 189-191). This should be extracted into a single helper function to avoid code duplication and improve maintainability.

Furthermore, using KoinPlatform.getKoin().get<...>() directly within a Composable is a Service Locator pattern. This couples your UI component to your dependency injection framework, making it harder to test and less reusable. A better approach is to pass navigation actions as lambda parameters to your composable (dependency injection).