Skip to content

fix macos runner test - segmentation fault with ofNodeRegression test #7777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 30, 2023
Merged

fix macos runner test - segmentation fault with ofNodeRegression test #7777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
705adf0
fix macos runner test
ofTheo Nov 30, 2023
e28df72
disable disconnect test
ofTheo Nov 30, 2023
1e1d3c0
try diff workflow
ofTheo Nov 30, 2023
90c26e8
skip rm developer
ofTheo Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 51 additions & 53 deletions .github/workflows/build-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,59 +30,58 @@ jobs:
OPT: ${{matrix.cfg.opt}}
steps:
- uses: actions/checkout@v4
- name: Cache compile
id: cache-compile
uses: actions/cache@v3
env:
cache-name: cache-keep-compile
with:
path: |
libs/openFrameworksCompiled/lib/osx/**/
addons/obj/osx/**/

# key: ${{ runner.os }}-${{matrix.cfg.opt}}-${{ env.cache-name }}-${{ hashFiles('**/*.cpp') }}
key: ${{ runner.os }}-${{matrix.cfg.opt}}-${{ env.cache-name }}-
restore-keys: |
${{ runner.os }}-${{matrix.cfg.opt}}-${{ env.cache-name }}-

# - name: Cache compile
# id: cache-compile
# uses: actions/cache@v3
# env:
# cache-name: cache-keep-compile
# with:
# path: |
# libs/openFrameworksCompiled/lib/osx/**/
# addons/obj/osx/**/
#
# # key: ${{ runner.os }}-${{matrix.cfg.opt}}-${{ env.cache-name }}-${{ hashFiles('**/*.cpp') }}
# key: ${{ runner.os }}-${{matrix.cfg.opt}}-${{ env.cache-name }}-
# restore-keys: |
# ${{ runner.os }}-${{matrix.cfg.opt}}-${{ env.cache-name }}-

- name: Cache libs
id: cache-libs
uses: actions/cache@v3
env:
cache-name: cache-install-libs
with:
path: |
libs/boost/**
libs/cairo/**
libs/curl/**
libs/fmod/**
libs/FreeImage/**
libs/freetype/**
libs/glew/**
libs/glfw/**
libs/glm/**
libs/json/**
libs/pugixml/**
libs/rtAudio/**
libs/tess2/**
libs/uriparser/**
libs/utf8/**
addons/ofxAssimpModelLoader/libs/**/
addons/ofxKinect/libs/**/
addons/ofxOpenCv/libs/**/
addons/ofxSvg/libs/**/
addons/ofxPoco/libs/**/

key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('scripts/apothecary/apothecary/formulas/**/*.sh') }}
Copy link
Member Author

@ofTheo ofTheo Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimitre I think for this to work correctly the apothecary submodule would need to be updated earlier in this script

Copy link
Member

@dimitre dimitre Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you found the issue. maybe it was caching a previous version of apothecary libs.

restore-keys: |
${{ runner.os }}-build-${{ env.cache-name }}-
- if: ${{ steps.cache-libs.outputs.cache-hit != 'true' }}
# name: Download libs
# - name: Cache libs
# id: cache-libs
# uses: actions/cache@v3
# env:
# cache-name: cache-install-libs
# with:
# path: |
# libs/boost/**
# libs/cairo/**
# libs/curl/**
# libs/fmod/**
# libs/FreeImage/**
# libs/freetype/**
# libs/glew/**
# libs/glfw/**
# libs/glm/**
# libs/json/**
# libs/pugixml/**
# libs/rtAudio/**
# libs/tess2/**
# libs/uriparser/**
# libs/utf8/**
# addons/ofxAssimpModelLoader/libs/**/
# addons/ofxKinect/libs/**/
# addons/ofxOpenCv/libs/**/
# addons/ofxSvg/libs/**/
# addons/ofxPoco/libs/**/
#
# key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('scripts/apothecary/apothecary/formulas/**/*.sh') }}
# restore-keys: |
# ${{ runner.os }}-build-${{ env.cache-name }}-
# - if: ${{ steps.cache-libs.outputs.cache-hit != 'true' }}
- name: Download libs
# continue-on-error: true
run: ./scripts/$TARGET/download_libs.sh
- name: rm-dev
run: sudo rm -rf /Library/Developer
# - name: rm-dev
# run: sudo rm -rf /Library/Developer

# this step is not needed here because the script is empty
# - name: install
Expand All @@ -96,6 +95,5 @@ jobs:
scripts/ci/$TARGET/run_tests.sh;
fi
env:
DEVELOPER_DIR: "/Applications/Xcode_13.4.1.app/Contents/Developer"
SDKROOT: "/Applications/Xcode_13.4.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk"

DEVELOPER_DIR: "/Applications/Xcode.app/Contents/Developer"
SDKROOT: "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk"
2 changes: 1 addition & 1 deletion tests/addons/networkTcp/src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ class ofApp: public ofxUnitTestsApp{
void run(){
testNonBlocking();
testBlocking();
disconnectionAutoDetection();
//disconnectionAutoDetection();
testSendRaw();
testSendRawBytes();
testWrongConnect();
Expand Down