Bug: unit name not translated in some event panel messages

[VariableVince]

Example the Dutch: "Jouw Port werd veroverd" where 'Port' is the English unit name instead of the Dutch 'Haven'.

So we have "Your {unit} was captured by {name}" (unit_captured_by_enemy). Here, {unit} needs to be localized. Probably by translating the unit name [ something like translateText("unit_type."+.this.type()), not simply sending this.type() ], when sending it from

OpenFrontIO/src/core/game/UnitImpl.ts

Line 213 in 1311725

{ unit: this.type(), name: newOwner.displayName() },

The above is one example, there are more strings like this.

[Michal-Martinek]

looks like translateText() should handle translating the params by itself

[VariableVince]

looks like translateText() should handle translating the params by itself

Think so too, as mentioned in the description

[slegarraga]

Hi! I'd like to work on this. The fix translates the unit type param in EventsDisplay.ts by converting the raw unit type string to a unit_type.* translation key before interpolation. Will submit a PR shortly.

[VariableVince]

@slegarraga Thanks! Assigned and sent a comment on the PR