increase nuke speed from 4 to 6

[evanpelle]

Description:

Since nukes take a curved/longer paths nukes take too long to reach their target. This PR increases their speed by 50%.

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
• I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors

Please put your Discord username so you can be contacted if a bug or regression is found:

evan

[coderabbitai]

Walkthrough

The default return value of the defaultNukeSpeed() method in the DefaultConfig class was changed from 4 to 6. No other logic or method signatures were altered in the file.

Changes

File	Change Summary
src/core/configuration/DefaultConfig.ts	Updated defaultNukeSpeed() to return 6 instead of 4.

Poem

The nuke now moves with greater speed,
From four to six, it takes the lead.
A tiny tweak, a simple line,
Now watch it go—oh, how it shines!
🚀

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-09T23_20_20_867Z-debug-0.log

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9401f20 and 3b286de.

📒 Files selected for processing (1)

• src/core/configuration/DefaultConfig.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Deploy to openfront.dev

[coderabbitai]

💡 Verification agent

🧩 Analysis chain

Bump default nuke speed from 4 to 6
The change matches the PR goal to speed up nukes by 50%. Please update any tests or docs that still refer to the old value.

Run this script to find references to defaultNukeSpeed (including tests or docs) and ensure they reflect the new default:

---

🏁 Script executed:

#!/bin/bash
# Find all references to defaultNukeSpeed
rg -n "defaultNukeSpeed" --glob "*.{ts,tsx,md}" 

Length of output: 711

---

Update tests to use the new default nuke speed of 6
The production default was bumped from 4 to 6—our test helpers and any hard-coded expectations need to match.

• tests/util/TestConfig.ts
– Change the initial _defaultNukeSpeed from 4 to 6.
• tests/SAM.test.ts (around line 156)
– If you’ve got any literal “/ 4” expectations, update them or defer to game.config().defaultNukeSpeed() so they follow the new default.

Example diff in TestConfig:

 tests/util/TestConfig.ts
-  private _defaultNukeSpeed: number = 4;
+  private _defaultNukeSpeed: number = 6;

Run the full suite afterward to confirm all time-to-target calculations still pass.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents

In src/core/configuration/DefaultConfig.ts around lines 754 to 756, the default
nuke speed was increased from 4 to 6. Update all related test files and
documentation that reference the old default value to reflect this change.
Specifically, in tests/util/TestConfig.ts, change the initial _defaultNukeSpeed
from 4 to 6, and in tests/SAM.test.ts near line 156, replace any hard-coded
divisions by 4 with the dynamic call to game.config().defaultNukeSpeed(). After
making these updates, run the full test suite to ensure all calculations and
tests pass correctly.