Skip to content

Comments

Update asset license#1458

Merged
evanpelle merged 1 commit intomainfrom
evan-update-license
Jul 17, 2025
Merged

Update asset license#1458
evanpelle merged 1 commit intomainfrom
evan-update-license

Conversation

@evanpelle
Copy link
Collaborator

@evanpelle evanpelle commented Jul 17, 2025

Description:

Update nc cc with commercial exemption for OpenFront LLC to be more clear.

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
  • I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors

Please put your Discord username so you can be contacted if a bug or regression is found:

evan

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 17, 2025

Walkthrough

The license file was fully rewritten, replacing a brief summary and link to the CC BY-NC 4.0 license with a detailed, formal agreement. The new license grants OpenFront LLC exclusive commercial rights and provides clear definitions, attribution rules, restrictions, and legal terms.

Changes

File(s) Change Summary
resources/non-commercial/LICENSE Replaced informal CC BY-NC 4.0 summary and exception with a comprehensive, formal license agreement

Possibly related PRs

Poem

A license reborn, with clauses anew,
For OpenFront’s path, commercial and true.
Definitions and rights, all set out with care,
Attribution rules, restrictions laid bare.
California law, signatures in sight—
Now all is clear, and usage is right!
📝✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@evanpelle evanpelle force-pushed the evan-update-license branch from 3fde35e to 9d480a3 Compare July 17, 2025 01:31
@evanpelle evanpelle merged commit b7d3871 into main Jul 17, 2025
8 of 18 checks passed
@evanpelle evanpelle deleted the evan-update-license branch July 17, 2025 01:32
@github-project-automation github-project-automation bot moved this from Triage to Complete in OpenFront Release Management Jul 17, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
resources/non-commercial/LICENSE (2)

25-30: Restriction 5(c) can clash with open-source tooling
Many build pipelines, minifiers, or image optimisers strip metadata by default. Absolute prohibition on “remove, obscure, or modify any … notice” could unintentionally put compliant engineers in breach. You could instead require “reasonable efforts” to preserve notices in user-visible contexts.


37-41: Governing-law clause may deter international contributors
Hard-coding California law might make EU or APAC adopters hesitant. A neutral clause (e.g. “Governing law: Licensor’s principal place of business unless otherwise required by local law”) can broaden appeal while still protecting the Licensor.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7af6c0 and 9d480a3.

📒 Files selected for processing (1)
  • resources/non-commercial/LICENSE (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: andrewNiziolek
PR: openfrontio/OpenFrontIO#1007
File: resources/lang/de.json:115-115
Timestamp: 2025-06-02T14:27:37.609Z
Learning: For OpenFrontIO project: When localization keys are renamed in language JSON files, the maintainers separate technical changes from translation content updates. They wait for community translators to update the actual translation values rather than attempting to translate in the same PR. This allows technical changes to proceed while ensuring accurate translations from native speakers.
🔇 Additional comments (2)
resources/non-commercial/LICENSE (2)

1-4: “Creative Commons” branding may be mis-used here
Calling this a “Creative Commons Non-Commercial License Agreement” while materially altering the standard CC-BY-NC 4.0 terms (e.g. adding revocability and an exclusive commercial carve-out) risks infringing Creative Commons’ trademark guidelines and confusing downstream users about their rights. Consider either:

  1. Distributing the assets under the unmodified CC-BY-NC 4.0 and granting OpenFront LLC a separate private licence, or
  2. Dropping the “Creative Commons” name entirely and treating this as a bespoke licence.

Please have legal counsel confirm the wording aligns with CC policy and trademark usage.


17-19: “Exclusive” commercial right may block future partnerships
Granting OpenFront LLC an exclusive worldwide commercial right prevents the Licensor from later authorising any other entity (even subsidiaries) unless wording like “exclusive to the extent not already granted” is added. Double-check that exclusivity, rather than simply “non-exclusive with priority”, is truly intended.

Comment on lines +14 to +16
2. License Grant (Non-Commercial Use)
Subject to the terms and conditions of this Agreement, Licensor hereby grants to Licensee a worldwide, royalty-free, non-exclusive, revocable license to use, copy, distribute, publicly perform, publicly display, and create derivative works of the Licensed Work solely for Non-Commercial purposes, provided that proper attribution is given as required under Section 4.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

“Revocable” contradicts the CC philosophy and weakens user certainty
A core appeal of CC licences is their irrevocability (except on breach). Making the grant “revocable” introduces legal risk for legitimate non-commercial users and may discourage adoption. If revocation is required, spell out objective conditions and notice periods. Otherwise consider removing the word.

🤖 Prompt for AI Agents
In resources/non-commercial/LICENSE around lines 14 to 16, the license grant is
described as "revocable," which contradicts the Creative Commons philosophy of
irrevocable licenses and may reduce user certainty. To fix this, remove the word
"revocable" from the license grant clause to align with standard CC license
terms, or alternatively, if revocation is necessary, explicitly define clear,
objective conditions and notice periods for revocation within the license text.

@github-project-automation github-project-automation bot moved this from Complete to Development in OpenFront Release Management Jul 17, 2025
@scottanderson scottanderson added this to the v24 milestone Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development

Development

Successfully merging this pull request may close these issues.

2 participants