Map fixes for Britannia and Pangaea

[Duwibi]

Description:

This PR fixes some small pixel errors on Pangaea and Britannia

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

DISCORD_USERNAME
Nikola123

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

Walkthrough

Two map manifest files receive numeric corrections to land tile counts. The Britannia map tile counts decreased across multiple scales, and Pangaea's primary map tile count decreased by one, reflecting data accuracy adjustments with no structural changes.

Changes

Cohort / File(s)	Summary
Map manifest tile count corrections resources/maps/britannia/manifest.json, resources/maps/pangaea/manifest.json	Updated num_land_tiles values: Britannia map decreased from 933706 to 933571; map16x from 55009 to 54975; map4x from 228914 to 228849. Pangaea map decreased from 420336 to 420335. All other manifest fields unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Verify numeric corrections align with actual map tile data
• Confirm no other manifest fields were inadvertently modified

Possibly related PRs

• fix: two rivers that were not connected fully #2422: Modifies the same num_land_tiles fields in britannia manifest that this PR further adjusts.
• fix number of land tiles fixes #1409 #1445: Updates corrected num_land_tiles values in britannia and pangaea manifests to address shore tile double-counting.
• fix odd dimension maps #1389: Corrects map manifest metadata including britannia land-tile counts and dimensions for map sizing accuracy.

Suggested labels

Feature - Map

Suggested reviewers

• evanpelle
• scottanderson

Poem

🗺️ The tiles align, the counts ring true,
Britannia's math now shines anew—
Numbers dance in perfect rows,
Where every map's precision grows. ✨

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: fixing map data for two specific maps (Britannia and Pangaea).
Description check	✅ Passed	The description is related to the changeset, explaining that it fixes small pixel errors on the Pangaea and Britannia maps, which aligns with the numeric corrections in the manifest files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e55b792 and d975693.

⛔ Files ignored due to path filters (8)

• map-generator/assets/maps/britannia/image.png is excluded by !**/*.png
• map-generator/assets/maps/pangaea/PangaeaThumb.png is excluded by !**/*.png
• map-generator/assets/maps/pangaea/image.png is excluded by !**/*.png
• resources/maps/britannia/map.bin is excluded by !**/*.bin
• resources/maps/britannia/map16x.bin is excluded by !**/*.bin
• resources/maps/britannia/map4x.bin is excluded by !**/*.bin
• resources/maps/pangaea/map.bin is excluded by !**/*.bin
• resources/maps/pangaea/map4x.bin is excluded by !**/*.bin

📒 Files selected for processing (2)

• resources/maps/britannia/manifest.json (1 hunks)
• resources/maps/pangaea/manifest.json (1 hunks)

🔇 Additional comments (2)

resources/maps/pangaea/manifest.json (1)

4-4: Verify the land tile count correction is complete and consistent across scales.

The Pangaea main map num_land_tiles decreased by 1 (420336 → 420335), but the downsampled scales (map16x and map4x) remain unchanged. Confirm this is intentional—if a pixel was removed from the primary map, the derived scales may need adjustment depending on the pixel location and downsampling algorithm.

resources/maps/britannia/manifest.json (1)

4-4: Confirm numeric corrections are validated by tests.

The Britannia manifest shows consistent proportional decreases across all three resolution tiers (main map -135 tiles, map4x -65, map16x -34). While the scale ratios remain consistent, the PR description and checklist indicate incomplete testing. Ensure that:

1. Tests exist to validate these num_land_tiles counts match the actual map data
2. The pixel-level corrections have been verified against the updated map files
3. The changes are reproducible and documented

The PR checklist shows unchecked items for tests and manual verification—please confirm these have been completed before merge.

Also applies to: 9-9, 14-14

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}