-
Notifications
You must be signed in to change notification settings - Fork 755
Feat: Singleplayer Achievements #2734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
736246b
feat: add MedalIconWhite SVG asset for UI
bijx 7753380
added medal row
bijx e5c1004
grayscale row
bijx 042b427
added win logic into localStorage
bijx f8e3619
renamed localStorage variable to be more reusable in the future
bijx 1b432de
make sure local win only counts for singleplayer games
bijx 6f75d78
added medal renderer, fixed win state, added medals only to singlepla…
bijx 51384bf
add toggle for achievements in Single Player mode
bijx 6acbc1d
realigned toggel acheivemetns button right
bijx 90ba5fc
added icon credits to credits file
bijx eb70ec1
added check to enforce settings are not tampered with to get award
bijx 6601553
put colors in a more reusable place
bijx d1f05f9
lint
bijx 26a8cc1
Merge branch 'main' into bijx/singleplayer-achievements
bijx 38f6b4d
Merge branch 'main' into bijx/singleplayer-achievements
bijx 90d28c8
Merge branch 'main' into bijx/singleplayer-achievements
bijx 819fb76
Merge branch 'main' into bijx/singleplayer-achievements
iiamlewis cbaa59a
Implement API call for recording singleplayer wins in ClientGameRunner
bijx 7c42e45
Merge branch 'bijx/singleplayer-achievements' of https://github.com/o…
bijx 5473a0a
Remove unused Difficulty and GameMapType imports in ClientGameRunner
bijx f86ce97
added back difficulty or custom check using default settings function
bijx 92f6812
added gameId to api call
bijx 3e0e9ca
implement API call to load singleplayer wins and update map wins stat…
bijx 175669d
updated singleplayer win recording to use user authentication and inc…
bijx fb9ca70
lint + format
bijx ad2a2ef
removed saving game stats from clientgamerunner since it now is handl…
bijx 4f2c5b4
remove other unused functions
bijx 6fcfb78
added new achievements shape to getUserMe response
bijx 51a9dac
replaced API call with listening for getUserMe response to render me…
bijx 7e5bd1b
lint + format
bijx 858638a
Merge branch 'main' into bijx/singleplayer-achievements
bijx 99f0374
added enum list for difficulty + custom to map completion schema
bijx 9cc040d
Merge branch 'main' into bijx/singleplayer-achievements
bijx 3426dfd
Merge branch 'main' into bijx/singleplayer-achievements
bijx e52e482
api schema updated to match backend
bijx 9d038bf
achievement fetching now follows new API shape
bijx 385424a
removed custom from possible medals
bijx 02d6a93
Merge branch 'main' into bijx/singleplayer-achievements
bijx ec04a88
Merge branch 'main' into bijx/singleplayer-achievements
bijx 2e17f87
Merge branch 'main' into bijx/singleplayer-achievements
evanpelle 6ef9d88
lint + format
bijx dcd42d3
Merge branch 'main' into bijx/singleplayer-achievements
bijx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 938
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 294
🏁 Script executed:
Repository: openfrontio/OpenFrontIO
Length of output: 1196
Fix the asset path for MedalIconWhite.svg.
The image path
/images/MedalIconWhite.svgis incorrect. The file is located atresources/images/MedalIconWhite.svg. Update line 151 to use the correct path, otherwise the medal icon will fail to load.Consider extracting inline styles for maintainability.
The toggle button works correctly, but the inline styles on lines 137, 145, and 150 make the template harder to read. However, since this component uses light DOM (
createRenderRoot()returnsthis), `static styles = css`` will not work. You can instead:<style>tag in the templateExtracting styles improves readability and makes changes easier to maintain.
🤖 Prompt for AI Agents