Fix Amazon River Map 🏞️ (one row of pixels too much)

[FloPinguin]

Description:

There was one row of white pixels at the top:

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

FloPinguin

[coderabbitai]

Walkthrough

The PR updates numeric values in the Amazon River map manifest file. It reduces map height and land tile counts across three map variants (base, 16x, and 4x), with no structural changes to the manifest format.

Changes

Cohort / File(s)	Summary
Map manifest numeric updates resources/maps/amazonriver/manifest.json	Adjusted map dimensions and land tile counts: base height 280→276 (1,172,808→1,150,819 tiles), 16x height 70→69 (71,047→69,690 tiles), 4x height 140→138 (290,101→284,707 tiles). Map widths unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• openfrontio/OpenFrontIO#2080: Modifies map manifest numeric fields across different map manifests with similar dimension and land tile adjustments.
• openfrontio/OpenFrontIO#1445: Reduces map num_land_tiles values in multiple map manifests, sharing the same adjustment pattern.
• openfrontio/OpenFrontIO#2798: Adds the Amazon River manifest file; this PR updates the numeric properties within that same manifest.

Suggested labels

Maps

Suggested reviewers

• evanpelle

Poem

📍 The Amazon flows with numbers precise,
Heights trimmed clean, like polished rice.
Tiles counted true, dimensions align,
A cartographer's careful, crafted design. ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main fix: adjusting the Amazon River map dimensions due to one extra row of pixels, which matches the manifest.json changes.
Description check	✅ Passed	The description is related to the changeset, explaining the visual issue being fixed with a screenshot and confirming testing and quality checks were completed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf1e67c and 6086b94.

⛔ Files ignored due to path filters (4)

• map-generator/assets/maps/amazonriver/image.png is excluded by !**/*.png
• resources/maps/amazonriver/map.bin is excluded by !**/*.bin
• resources/maps/amazonriver/map16x.bin is excluded by !**/*.bin
• resources/maps/amazonriver/map4x.bin is excluded by !**/*.bin

📒 Files selected for processing (2)

• resources/maps/amazonriver/manifest.json
• resources/maps/amazonriver/thumbnail.webp

🔇 Additional comments (2)

resources/maps/amazonriver/manifest.json (2)

3-5: Height reductions are proportionally consistent across all map variants.

The height changes correctly maintain the scaling relationships between variants:

• Base map: -4 pixels (280 → 276)
• map16x (4x downscaled): -1 pixel (70 → 69)
• map4x (2x downscaled): -2 pixels (140 → 138)

The land tile count reductions are proportionally consistent: removing 4 rows from a 5536-width map would remove up to 22,144 tiles, and the actual reduction of 21,989 tiles suggests the removed top row was approximately 99% land pixels.

The manifest values are correctly set. However, note that this codebase stores map data in binary .bin files, not image files. The binary files (map.bin, map16x.bin, map4x.bin) should be verified to match the new dimensions, but this cannot be done in the sandbox environment.

Likely an incorrect or invalid review comment.

---

18-124: Verify whether rows were actually removed from the map image.

The review comment suggests that 4 rows were removed from the top of the map, but the current manifest shows height: 276 with the smallest Y coordinates at 7 and 8. If rows were removed and coordinates needed adjustment, the manifest height should reflect the reduction (272 instead of 276) and the Y coordinates would be 11 and 12 (7+4, 8+4), not 7 and 8.

The code shows no offset logic for removed rows—nation coordinates from the manifest are used directly without adjustment (except for Compact maps, which divide by 2). All coordinate values are valid for a height-276 map.

Either:

• The map image was not actually modified, or
• The coordinate values in the manifest are correct as-is for the current map dimensions

Check the map dimensions and image to clarify whether rows were removed. If they were, both the manifest height and all Y coordinates require adjustment. If they were not, this review comment is incorrect.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}