Skip to content

Remove win modal animation 🖌️#3230

Merged
ryanbarlow97 merged 2 commits intomainfrom
remove-win-modal-animation
Feb 17, 2026
Merged

Remove win modal animation 🖌️#3230
ryanbarlow97 merged 2 commits intomainfrom
remove-win-modal-animation

Conversation

@FloPinguin
Copy link
Contributor

Description:

Win modal animation looks bugged (https://youtu.be/fmR4nZL5RLg?t=3839)
Just remove it, make the game feel snappier
Reported by Wonder

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

FloPinguin

@FloPinguin FloPinguin added this to the v30 milestone Feb 17, 2026
@FloPinguin FloPinguin requested a review from a team as a code owner February 17, 2026 20:32
@FloPinguin FloPinguin added the UI/UX UI/UX changes including assets, menus, QoL, etc. label Feb 17, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

A fade-in animation has been removed from the modal window component. The CSS animation class animate-fadeIn and its corresponding keyframe definition have been deleted from the component file, while the modal rendering logic remains unchanged.

Changes

Cohort / File(s) Summary
Modal Animation Removal
src/client/graphics/layers/WinModal.ts
Removed the animate-fadeIn CSS class application from the modal container and deleted the associated @keyframes animation definition. Core modal rendering and state management unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

✨ A fade dissolves into plain sight,
The modal stands without its dance—
Simple now, no flash of light,
Clean and direct at first glance! 🎭

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove win modal animation 🖌️' clearly and directly summarizes the main change - removing an animation from the win modal component.
Description check ✅ Passed The description is directly related to the changeset, explaining why the animation is being removed (it looks bugged) and the intended benefit (snappier feel).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@evanpelle evanpelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ryanbarlow97
Copy link
Contributor

cheers

@github-project-automation github-project-automation bot moved this from Triage to Final Review in OpenFront Release Management Feb 17, 2026
@ryanbarlow97 ryanbarlow97 added this pull request to the merge queue Feb 17, 2026
Merged via the queue into main with commit f276a72 Feb 17, 2026
11 checks passed
@ryanbarlow97 ryanbarlow97 deleted the remove-win-modal-animation branch February 17, 2026 20:37
@github-project-automation github-project-automation bot moved this from Final Review to Complete in OpenFront Release Management Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI/UX UI/UX changes including assets, menus, QoL, etc.

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants

Comments