Expand Aegean Map for balancing purposes#3459
Conversation
WalkthroughAegean map data and manifest were updated: numerous nation coordinates changed, Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@map-generator/assets/maps/aegean/info.json`:
- Around line 76-79: Update the place name value "Eubonia" to the correct
"Euboea" in this JSON entry (the object with "coordinates": [534, 761] and
"name") and make the identical correction in the corresponding manifest.json so
both files remain in sync.
In `@resources/maps/aegean/manifest.json`:
- Around line 91-94: The manifest contains an island entry with "name":
"Eubonia" (coordinates [534, 761]) which appears to be a typo; update the "name"
value to "Euboea" in that JSON object (or confirm and document if "Eubonia" was
intentional) so the island name is correctly spelled where the manifest defines
the island entry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: af3febc2-e618-4cd2-840c-c7b5a279e264
⛔ Files ignored due to path filters (4)
map-generator/assets/maps/aegean/image.pngis excluded by!**/*.pngresources/maps/aegean/map.binis excluded by!**/*.binresources/maps/aegean/map16x.binis excluded by!**/*.binresources/maps/aegean/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (3)
map-generator/assets/maps/aegean/info.jsonresources/maps/aegean/manifest.jsonresources/maps/aegean/thumbnail.webp
github-project-automation
bot
moved this from Triage
to Development
in OpenFront Release Management
change Euboea
There was a problem hiding this comment.
🧹 Nitpick comments (1)
resources/maps/aegean/manifest.json (1)
18-138: Nations list expansion looks good for balancing.Adding 12 new nations on the Greek side and islands aligns with the PR goal of balancing gameplay. The coordinates match
info.jsonand fall within the new map bounds.One small note: The property order differs between the two files (
flagappears beforenamehere but afternameininfo.jsonfor entries like Achaemenid Empire, Athens, Sparta, Macedonia). This is not a functional issue since JSON object property order does not matter, but it may help future maintainability to keep them consistent.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@resources/maps/aegean/manifest.json` around lines 18 - 138, The nation entries with both a "name" and "flag" property (notably "Achaemenid Empire", "Athens", "Sparta", and "Macedonia") have the properties in a different order than in info.json; reorder each of those objects so the "name" property appears before the "flag" property to match the other file for consistency and maintainability.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@resources/maps/aegean/manifest.json`:
- Around line 18-138: The nation entries with both a "name" and "flag" property
(notably "Achaemenid Empire", "Athens", "Sparta", and "Macedonia") have the
properties in a different order than in info.json; reorder each of those objects
so the "name" property appears before the "flag" property to match the other
file for consistency and maintainability.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6ce8b1f5-911e-4fc6-870e-03c30d5c4c8d
📒 Files selected for processing (2)
map-generator/assets/maps/aegean/info.jsonresources/maps/aegean/manifest.json
switch name and flag positions
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@resources/maps/aegean/manifest.json`:
- Around line 127-129: The JSON entry with "coordinates": [723, 643] currently
uses the island name "Scyrus" which appears to be a typo; update the "name"
value from "Scyrus" to "Scyros" in that object (the JSON object containing the
coordinates and name fields) so it matches the classical spelling used
elsewhere.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3e08457d-80f5-44cf-b09a-de44ae22e662
📒 Files selected for processing (1)
resources/maps/aegean/manifest.json
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@resources/maps/aegean/manifest.json`:
- Around line 24-57: The manifest's nation objects are missing the required
"flag" string property (Nation interface used by
src/core/game/TerrainMapLoader.ts) causing direct access in
src/core/game/GameView.ts (line ~675) to fail; update each of the 25 entries
(Crete, Rhodes, Lesbos, Chios, Samos, Troy, Ephesus, Miletus, Lemnos, Thrace,
Thasos, Thessaly, Aetolia, Euboea, Olympia, Andros, Icaria, Naxos, Thera, Ios,
Cos, Melos, Scyros, Cythera, Carpathos) to include a "flag": "NationName" field
(use the nation name string as the flag value) and verify corresponding SVG
files exist in resources/flags/ so GameView.ts can safely access nation.flag.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a3c0c117-dc49-42e4-871e-c2b7b8b525a9
📒 Files selected for processing (2)
map-generator/assets/maps/aegean/info.jsonresources/maps/aegean/manifest.json
github-project-automation
bot
moved this from Development
to Final Review
in OpenFront Release Management
github-project-automation
bot
moved this from Final Review
to Complete
in OpenFront Release Management
2 participants
Description:
Expands the Aegean map to the left. Currently the 2 major landmasses are unbalanced, which causes the eastern side to almost always win, both in FFA and team games.
Original Width: 1600px | New Width=1700px
Also adds more nations / NPCs in the Greek side to create more balance with the Turkish side, aswell as in the islands, to compensate for the lack of bots / tribes spawning in there, to boost early island gameplay and fasten games.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
tri.star1011