Remove modifiers from normal FFA/Team games (And increase chance of gold multiplier for special games, decrease random spawn) 🎲

[FloPinguin]

Description:

Normal (FFA and Team) public games no longer roll random modifiers.
Special games remain fully unaffected and continue to use random modifiers as before.

I also increased the gold multiplier ticket count in the special modifier pool from 1 to 4 because of player feedback.

Edit: And because I saw complaints of too much random spawn I decreased the chance of it.

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

FloPinguin

[coderabbitai]

Walkthrough

Removes randomized public-game modifier generation, replacing it with fixed baseline settings for non-"special" games; increases the selection weight for the goldMultiplier special modifier; reorganizes getSpecialConfig with added checks and comments and deletes the private random-modifier helper.

Changes

Cohort / File(s)	Summary
Playlist core src/server/MapPlaylist.ts	Removed getRandomPublicGameModifiers and all random-public-modifier logic; non-"special" gameConfig(...) now returns deterministic values (gameMapSize=Normal, randomSpawn=false, isCompact/isCrowded/isHardNations=false, bots=400, startingGold removed, difficulty based only on team type, spawnImmunityDuration recomputed without startingGold).
Special modifiers src/server/MapPlaylist.ts	Increased goldMultiplier tickets in SPECIAL_MODIFIER_POOL from 1 to 4; reordered and added checks in getSpecialConfig (e.g., supportsCompact, duo/trio/quad isRandomSpawn exclusions) while preserving special modifier selection and crowded/max-player adjustments; added clarifying comments.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

Gold chance grows, a heavier draw,
Random tweaks fall to a law.
Baselines set, the playlist sings,
Clearer paths and steadier wings. ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately reflects the main changes: removing modifiers from normal games and adjusting special game modifiers (gold multiplier increase and random spawn decrease).
Description check	✅ Passed	The description is directly related to the changeset, explaining the removal of random modifiers from normal games and the adjustments to special games, with clear rationale.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/server/MapPlaylist.ts`:
- Around line 154-160: The MapPlaylist baseline currently sets
publicGameModifiers but omits the actual rule flag disableAlliances, so update
the normal-game baseline in MapPlaylist (the publicGameModifiers block) to
explicitly set disableAlliances as well; ensure the same boolean value used for
isAlliancesDisabled is applied to disableAlliances so GameServer (which copies
disableAlliances when defined) receives the explicit rule and behaves
consistently with the special branch.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 82c9b0f7-aeec-4c5d-aac7-a0c51d2164b5

📥 Commits

Reviewing files that changed from the base of the PR and between 9bd3570 and 1ef1250.

📒 Files selected for processing (1)

• src/server/MapPlaylist.ts

[evanpelle]

thanks!