Add Closed-Back for april-folls#3548
Conversation
|
|
WalkthroughA new language locale "cb" (closed bak) is introduced by adding complete translation strings in a JSON resource file and registering the locale in the metadata with name and flag identifier. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@resources/lang/cb.json`:
- Around line 1-542: The cb.json locale changes should not be included in a
regular feature PR; revert or remove the edits to resources/lang/cb.json (and
any other non-en locale files) from this branch and instead submit them via the
dedicated translation workflow used for resources/lang/*.json (only en.json may
be edited in normal PRs); reference the file resources/lang/cb.json to locate
the change to undo and ensure the PR only contains allowed localization edits
per the repo translation process.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: da1d1089-f7cc-4135-a1c2-69050bd063d2
⛔ Files ignored due to path filters (1)
resources/flags/cb_flag.svgis excluded by!**/*.svg
📒 Files selected for processing (2)
resources/lang/cb.jsonresources/lang/metadata.json
|
can we make it default for en lang? |
## Description: Add Closed-Back for april-folls ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced ## Please put your Discord username so you can be contacted if a bug or regression is found: aotumuri
Description:
Add Closed-Back for april-folls
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
aotumuri