Skip to content

Add Closed-Back for april-folls#3548

Merged
evanpelle merged 1 commit intoopenfrontio:mainfrom
Aotumuri:front-back
Apr 1, 2026
Merged

Add Closed-Back for april-folls#3548
evanpelle merged 1 commit intoopenfrontio:mainfrom
Aotumuri:front-back

Conversation

@Aotumuri
Copy link
Copy Markdown
Member

Description:

Add Closed-Back for april-folls

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

aotumuri

@Aotumuri Aotumuri added the Translation Addition or modification of a language to the translations. label Mar 31, 2026
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 31, 2026

Walkthrough

A new language locale "cb" (closed bak) is introduced by adding complete translation strings in a JSON resource file and registering the locale in the metadata with name and flag identifier.

Changes

Cohort / File(s) Summary
Language Localization
resources/lang/cb.json, resources/lang/metadata.json
Adds new locale "cb" with 542 translation entries across common UI sections (labels, modals, maps, chat, gameplay, errors) and metadata registration with native name "closed bak" and flag identifier.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🌐 A new voice joins the chorus, doors unlock with gentle keys,
Translation maps unfold like maps of lands across the seas,
"cb" whispers in the metadata, where flags and names align,
Five hundred strings in harmony—a language wholly fine! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add Closed-Back for april-folls' directly describes the main change—adding a new localization resource for the 'Closed-Back' language variant for what appears to be an April Fools feature.
Description check ✅ Passed The description clearly relates to the changeset by stating 'Add Closed-Back for april-folls' and includes a checklist confirming UI updates, text localization, tests, and thorough testing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@resources/lang/cb.json`:
- Around line 1-542: The cb.json locale changes should not be included in a
regular feature PR; revert or remove the edits to resources/lang/cb.json (and
any other non-en locale files) from this branch and instead submit them via the
dedicated translation workflow used for resources/lang/*.json (only en.json may
be edited in normal PRs); reference the file resources/lang/cb.json to locate
the change to undo and ensure the PR only contains allowed localization edits
per the repo translation process.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: da1d1089-f7cc-4135-a1c2-69050bd063d2

📥 Commits

Reviewing files that changed from the base of the PR and between 6fa9bf6 and 382e520.

⛔ Files ignored due to path filters (1)
  • resources/flags/cb_flag.svg is excluded by !**/*.svg
📒 Files selected for processing (2)
  • resources/lang/cb.json
  • resources/lang/metadata.json

Comment thread resources/lang/cb.json
@github-project-automation github-project-automation Bot moved this from Triage to Development in OpenFront Release Management Mar 31, 2026
@ryanbarlow97
Copy link
Copy Markdown
Contributor

can we make it default for en lang?

@github-project-automation github-project-automation Bot moved this from Development to Final Review in OpenFront Release Management Apr 1, 2026
@evanpelle evanpelle marked this pull request as ready for review April 1, 2026 04:49
@evanpelle evanpelle requested a review from a team as a code owner April 1, 2026 04:49
@evanpelle evanpelle merged commit 6f3da9c into openfrontio:main Apr 1, 2026
7 of 8 checks passed
@github-project-automation github-project-automation Bot moved this from Final Review to Complete in OpenFront Release Management Apr 1, 2026
evanpelle pushed a commit that referenced this pull request Apr 1, 2026
## Description:

Add Closed-Back for april-folls

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced

## Please put your Discord username so you can be contacted if a bug or
regression is found:
aotumuri
evanpelle added a commit that referenced this pull request Apr 2, 2026
evanpelle added a commit that referenced this pull request Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Translation Addition or modification of a language to the translations.

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

5 participants