Skip to content

add Baja California map 🏜️#3759

Merged
evanpelle merged 3 commits into
openfrontio:mainfrom
RickD004:bajacalifornia
Apr 25, 2026
Merged

add Baja California map 🏜️#3759
evanpelle merged 3 commits into
openfrontio:mainfrom
RickD004:bajacalifornia

Conversation

@RickD004
Copy link
Copy Markdown
Contributor

Description:

Adds map of the Baja California peninsula in Mexico. Majority of this map is brown terrain to simulate the (Sonora) desert
Mexican and American states as NPCs. The peninsula while having little landmass is balanced by the fact it will be very easy to pirate from it

Captura de pantalla 2026-04-18 151337

Relief data from OpenTopography, already credited

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 15a066ea-1d51-4cc0-b16e-77c2014e3a1a

📥 Commits

Reviewing files that changed from the base of the PR and between 4a17642 and 2745b24.

⛔ Files ignored due to path filters (2)
  • resources/maps/bajacalifornia/map16x.bin is excluded by !**/*.bin
  • resources/maps/bajacalifornia/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (2)
  • resources/maps/bajacalifornia/manifest.json
  • resources/maps/bajacalifornia/thumbnail.webp
✅ Files skipped from review due to trivial changes (1)
  • resources/maps/bajacalifornia/manifest.json

Walkthrough

Adds a new playable map "Baja California" across assets, localization, manifest, generator registration, type definitions, and playlist weighting so it is selectable and rendered at multiple resolutions.

Changes

Cohort / File(s) Summary
Map Generator & Assets
map-generator/main.go, map-generator/assets/maps/bajacalifornia/info.json
Register bajacalifornia in the generator and provide map metadata: display name and list of nations with coordinates, names, and flag IDs.
Map Manifest & Resources
resources/maps/bajacalifornia/manifest.json, resources/lang/en.json
Add manifest declaring sizes (map, map16x, map4x), land tile counts, and nations; add English localization key map.bajacalifornia = "Baja California".
Game Type System
src/core/game/Game.ts
Add BajaCalifornia = "Baja California" to GameMapType and include it in the regional category.
Playlist Configuration
src/server/MapPlaylist.ts
Include BajaCalifornia in playlist frequency weighting (frequency set to 4).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🌵 Baja lands unfurl in code and name,
Flags and coords join the mapping game,
A manifest, a type, a list made new,
Playlists hum where coastlines brew,
One small file brings a broader view.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'add Baja California map 🏜️' clearly and concisely describes the main change—adding a new map to the game. It is specific and accurately reflects the primary objective of the PR.
Description check ✅ Passed The description is directly related to the changeset, explaining the Baja California map's purpose, terrain characteristics, NPC nations, and game balance considerations. It includes relevant details about data sources and testing completion.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 25, 2026
@evanpelle
Copy link
Copy Markdown
Collaborator

can you rebase onto main and re-run the map generator, this PR might change the output: 4ae1fa2

@RickD004
Copy link
Copy Markdown
Contributor Author

RickD004 commented Apr 25, 2026

re-did map with updated map generator. I attach how the map works on compact , removing all islands smaller than 15px
image

@github-project-automation github-project-automation Bot moved this from Triage to Final Review in OpenFront Release Management Apr 25, 2026
@evanpelle evanpelle added this to the v31 milestone Apr 25, 2026
@evanpelle evanpelle merged commit 32a254b into openfrontio:main Apr 25, 2026
10 of 11 checks passed
@github-project-automation github-project-automation Bot moved this from Final Review to Complete in OpenFront Release Management Apr 25, 2026
@RickD004 RickD004 deleted the bajacalifornia branch April 25, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants