Adds Map of the Yellow Sea#4026
Merged
Merged
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds the "Yellow Sea" regional map: new asset and manifest files, registers the map in the generator and game enums/categories, adds an English label, and assigns playlist frequency weight 5. ChangesYellow Sea Map Registration
Sequence Diagram(s)sequenceDiagram
participant MapGenerator
participant InfoJSON
participant ManifestJSON
MapGenerator->>InfoJSON: load `map-generator/assets/maps/yellowsea/info.json`
MapGenerator->>ManifestJSON: reference `resources/maps/yellowsea/manifest.json`
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/core/game/Game.ts`:
- Line 179: Add two targeted tests: one asserting the enum value
GameMapType.YellowSea is exactly the string "Yellow Sea", and another asserting
mapCategories.regional includes GameMapType.YellowSea; place them in the
existing tests/MapConsistency.test.ts (or a nearby map-specific test file) so
they run with the rest of map consistency checks, using the existing imports for
GameMapType and mapCategories and straightforward equality/inclusion assertions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4a73f0c3-cc59-4e45-8c43-233baa53f4bf
⛔ Files ignored due to path filters (4)
map-generator/assets/maps/yellowsea/image.pngis excluded by!**/*.pngresources/maps/yellowsea/map.binis excluded by!**/*.binresources/maps/yellowsea/map16x.binis excluded by!**/*.binresources/maps/yellowsea/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (7)
map-generator/assets/maps/yellowsea/info.jsonmap-generator/main.goresources/lang/en.jsonresources/maps/yellowsea/manifest.jsonresources/maps/yellowsea/thumbnail.webpsrc/core/game/Game.tssrc/server/MapPlaylist.ts
github-project-automation
Bot
moved this from Triage
to Development
in OpenFront Release Management
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@resources/lang/en.json`:
- Around line 607-610: The JSON has a syntax error and a duplicate key: add the
missing comma after the "yellowsea": "Yellow Sea" entry and remove the duplicate
"balkans" entry so "balkans" appears only once (keep the intended value for the
"balkans" key and ensure "labyrinth" remains present); check the object
containing "balkans", "yellowsea", and "labyrinth" to confirm valid JSON and
unique keys.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: dc8b0e64-1ea5-40f0-8b9c-1881b69458cb
📒 Files selected for processing (4)
map-generator/main.goresources/lang/en.jsonsrc/core/game/Game.tssrc/server/MapPlaylist.ts
🚧 Files skipped from review as they are similar to previous changes (3)
- src/core/game/Game.ts
- map-generator/main.go
- src/server/MapPlaylist.ts
Contributor
|
@coderabbitai approve |
Contributor
✅ Actions performedComments resolved and changes approved. |
evanpelle
approved these changes
May 28, 2026
github-project-automation
Bot
moved this from Development
to Final Review
in OpenFront Release Management
github-project-automation
Bot
moved this from Final Review
to Complete
in OpenFront Release Management
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
"A high-stakes naval theater where empires clash over narrow corridors, bottleneck straits, and heavily fortified shorelines."
Modeled to the exact strategic proportions of the classic Black Sea map, Yellow Sea shifts the focus of global conflict to East Asia. The map is defined by its massive central body of water, making naval dominance absolutely essential for survival. However, unlike wide-open oceans, control of the Yellow Sea is entirely dictated by its unique coastal geography.
The Shandong And Liaoning Peninsulas are The definitive feature of the map. Two massive, opposing peninsulas project deep into the sea, acting as natural, heavily contestable daggers. They create tight naval choke points in the central waters while forcing land-based players into brutal, linear frontlines where every pixel of territory is bought with blood.
The Continental Rim: A sprawling mainland coast wraps around the northern and western edges of the map, offering expansive land routes for players who prefer sweeping land invasions over amphibious assaults.
Scale Class: Medium
Gameplay Style: Naval/Land Hybrid, Tactical Choke Points, Frontline Bottlenecks
Nations: 8
North Korea South Korea Liaoning Shandong Beijing Hebei Tianjin Jilin
description mostly generated by google gemini ai
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
DISCORD_USERNAME crunchybbbbb
Game play video https://youtu.be/IcRPTM0rHM0