Skip to content

Take off the v32 maps from the "New" category to make room for v33 maps#4378

Open
RickD004 wants to merge 1 commit into
openfrontio:mainfrom
RickD004:v33maps
Open

Take off the v32 maps from the "New" category to make room for v33 maps#4378
RickD004 wants to merge 1 commit into
openfrontio:mainfrom
RickD004:v33maps

Conversation

@RickD004

Copy link
Copy Markdown
Contributor

Resolves #4375

Description:

Remove V32 maps from "new" to make way for v33 maps. This will allow map makers to add their new maps for v33 into "new", with the v32 maps only remaining in the continental and other categories like the rest of the maps. This is a process we will make every update

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 697533b2-154b-4308-b84b-63cefaaaad6f

📥 Commits

Reviewing files that changed from the base of the PR and between d8395fa and 79f2458.

📒 Files selected for processing (41)
  • map-generator/assets/maps/balkans/info.json
  • map-generator/assets/maps/caribbean/info.json
  • map-generator/assets/maps/choppingblock/info.json
  • map-generator/assets/maps/danishstraits/info.json
  • map-generator/assets/maps/hongkong/info.json
  • map-generator/assets/maps/indiansubcontinent/info.json
  • map-generator/assets/maps/juandefucastrait/info.json
  • map-generator/assets/maps/korea/info.json
  • map-generator/assets/maps/labyrinth/info.json
  • map-generator/assets/maps/middleeast/info.json
  • map-generator/assets/maps/mississippiriver/info.json
  • map-generator/assets/maps/northwestpassage/info.json
  • map-generator/assets/maps/onion/info.json
  • map-generator/assets/maps/southeastasia/info.json
  • map-generator/assets/maps/taiwanstrait/info.json
  • map-generator/assets/maps/titan/info.json
  • map-generator/assets/maps/venice/info.json
  • map-generator/assets/maps/warshipwarship/info.json
  • map-generator/assets/maps/worldinverted/info.json
  • map-generator/assets/maps/yellowsea/info.json
  • resources/maps/balkans/manifest.json
  • resources/maps/caribbean/manifest.json
  • resources/maps/choppingblock/manifest.json
  • resources/maps/danishstraits/manifest.json
  • resources/maps/hongkong/manifest.json
  • resources/maps/indiansubcontinent/manifest.json
  • resources/maps/juandefucastrait/manifest.json
  • resources/maps/korea/manifest.json
  • resources/maps/labyrinth/manifest.json
  • resources/maps/middleeast/manifest.json
  • resources/maps/mississippiriver/manifest.json
  • resources/maps/northwestpassage/manifest.json
  • resources/maps/onion/manifest.json
  • resources/maps/southeastasia/manifest.json
  • resources/maps/taiwanstrait/manifest.json
  • resources/maps/titan/manifest.json
  • resources/maps/venice/manifest.json
  • resources/maps/warshipwarship/manifest.json
  • resources/maps/worldinverted/manifest.json
  • resources/maps/yellowsea/manifest.json
  • src/core/game/Maps.gen.ts

Walkthrough

The "new" category is removed from the categories array of 20 maps. Each map is updated in three places: its info.json source file, its manifest.json resource file, and the generated Maps.gen.ts TypeScript metadata. One map (WarshipWarship) also has its multiplayerFrequency value changed.

Changes

Remove "new" category from V32 maps

Layer / File(s) Summary
Remove "new" from map-generator info files
map-generator/assets/maps/*/info.json
The categories array in each of the 20 map source info files is updated to drop the "new" entry, keeping only the region or theme tag (e.g., "europe", "asia", "arcade", "cosmic").
Remove "new" from resource manifest files
resources/maps/*/manifest.json
The same "new" removal is applied to each map's corresponding manifest file in the resources directory.
Update generated TypeScript metadata
src/core/game/Maps.gen.ts
The generated map metadata file reflects the category changes for all 20 maps. WarshipWarship also has its multiplayerFrequency value updated alongside the category change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openfrontio/OpenFrontIO#4105: Adds and registers the Southeast Asia map, which is one of the maps whose "new" category is removed in this PR.
  • openfrontio/OpenFrontIO#4231: Refactors src/core/game/Maps.gen.ts to expose categories per map, the same field this PR modifies across many entries.
  • openfrontio/OpenFrontIO#4254: Directly modifies the same per-map categories metadata in info.json, manifest.json, and Maps.gen.ts — adding "new" to the same maps this PR removes it from.

Suggested reviewers

  • evanpelle

Poem

🗺️ The maps were once shiny and new,
But v33 brings a fresh set to view.
With "new" removed from the list,
No old map will be missed.
The shelf is now clear — time to debut! 🚀

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main objective of the PR: removing v32 maps from the 'New' category to make room for v33 maps.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of removing v32 maps from the 'New' category and the process for future updates.
Linked Issues check ✅ Passed The PR fully addresses the objective from linked issue #4375: removing v32 maps from the 'New' category across all affected map metadata files (both in map-generator and resources directories).
Out of Scope Changes check ✅ Passed All changes are scoped to removing the 'new' category from v32 maps in their metadata files, with one minor adjustment to WarshipWarship's multiplayerFrequency that appears to be a related maintenance change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

Remove V32 maps from "new" to make way for v33 maps

1 participant