Skip to content

Add deploy concurrency configuration#911

Merged
evanpelle merged 1 commit intomainfrom
deploy
May 28, 2025
Merged

Add deploy concurrency configuration#911
evanpelle merged 1 commit intomainfrom
deploy

Conversation

@scottanderson
Copy link
Contributor

Description:

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs

Please complete the following:

  • I have added screenshots for all UI updates
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
  • I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 28, 2025

Walkthrough

The deploy workflow for GitHub Actions was updated to add concurrency control. Now, workflow runs are grouped by workflow name and Git reference, and new runs will not cancel any in-progress runs for the same group. No other parts of the workflow were changed.

Changes

File(s) Change Summary
.github/workflows/deploy.yml Added concurrency block to control simultaneous workflow runs

Suggested reviewers

  • evanpelle

Poem

In the land of deploy, where workflows roam,
Concurrency keeps each job in its home.
No more canceling, let each run proceed—
A gentle update for the pipelines' need.
So here's to control, calm and precise,
May your deploys be steady, and always nice! 🚀


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@scottanderson scottanderson added this to the v24 milestone May 28, 2025
@github-project-automation github-project-automation bot moved this from Triage to Final Review in OpenFront Release Management May 28, 2025
@evanpelle evanpelle merged commit e2fc114 into main May 28, 2025
9 of 10 checks passed
@evanpelle evanpelle deleted the deploy branch May 28, 2025 02:26
@github-project-automation github-project-automation bot moved this from Final Review to Complete in OpenFront Release Management May 28, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/deploy.yml (1)

39-42: Add concurrency control to queue deploys per branch

The new concurrency block groups runs by workflow name and Git reference, so new runs wait instead of canceling in-flight deployments. This prevents overlapping deploys on the same branch.

Consider refining the group key for clarity and flexibility:

  • Use ${{ github.ref_name }} instead of ${{ github.ref }} to avoid including slash characters.
  • Optionally include ${{ inputs.target_domain }} if you want separate queues per deployment target.
- concurrency:
-   group: ${{ github.workflow }}-${{ github.ref }}
-   cancel-in-progress: false
+ concurrency:
+   group: ${{ github.workflow }}-${{ github.ref_name }}
+   cancel-in-progress: false
# Or, to allow parallel deploys to different domains:
+   group: ${{ github.workflow }}-${{ github.ref_name }}-${{ inputs.target_domain }}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d8ad9e2 and 39ea305.

📒 Files selected for processing (1)
  • .github/workflows/deploy.yml (1 hunks)

@coderabbitai coderabbitai bot mentioned this pull request May 29, 2025
5 tasks
ghisloufou pushed a commit to ghisloufou/OpenFrontIO that referenced this pull request Jun 8, 2025
## Description:


https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I understand that submitting code with bugs that could have been
caught through manual testing blocks releases and new features for all
contributors

Co-authored-by: Scott Anderson <662325+scottanderson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants