Conversation
WalkthroughThe deploy workflow for GitHub Actions was updated to add concurrency control. Now, workflow runs are grouped by workflow name and Git reference, and new runs will not cancel any in-progress runs for the same group. No other parts of the workflow were changed. Changes
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/deploy.yml (1)
39-42: Add concurrency control to queue deploys per branchThe new
concurrencyblock groups runs by workflow name and Git reference, so new runs wait instead of canceling in-flight deployments. This prevents overlapping deploys on the same branch.Consider refining the group key for clarity and flexibility:
- Use
${{ github.ref_name }}instead of${{ github.ref }}to avoid including slash characters.- Optionally include
${{ inputs.target_domain }}if you want separate queues per deployment target.- concurrency: - group: ${{ github.workflow }}-${{ github.ref }} - cancel-in-progress: false + concurrency: + group: ${{ github.workflow }}-${{ github.ref_name }} + cancel-in-progress: false # Or, to allow parallel deploys to different domains: + group: ${{ github.workflow }}-${{ github.ref_name }}-${{ inputs.target_domain }}
## Description: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced - [x] I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors Co-authored-by: Scott Anderson <662325+scottanderson@users.noreply.github.com>
Description:
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs
Please complete the following: