💚(ci) fix check-changelog, mongo tests, tray and test-helm#634
Merged
Conversation
- Replace removed `git whatchanged` (refused by git >= 2.47) with `git log --name-only` in the check-changelog CI job. - Assert only on the stable "Failed to delete document chunk: " prefix in the mongo delete-failure tests, instead of the exact pymongo/bson error string which varies across pymongo versions.
The tray job runs Arnold with an unpinned `master` image tag. Arnold's `latest`/`master` moved to 6.24.0 (ansible-core 2.14.18), whose vault handling breaks the "Decrypt vaulted credentials" step, turning tray red without any code change (green->red on unrelated PRs). Pin the Arnold image (Makefile + .k3d-cluster.env.sh) and the downloaded `bin/arnold` / `bin/init-cluster` wrappers to 6.23.0 (ansible-core 2.14.17), the last release before the regression.
The test-helm job installed the ECK operator from an unpinned chart and then waited on pods with a 5s sleep. The freshly installed operator was not ready yet, so no pods existed and `kubectl wait` failed immediately with "no matching resources found". Pin eck-operator to 2.16.1, wait for the operator to be ready before applying the Elasticsearch CR, and wait on the Elasticsearch resource status (which exists right after apply) instead of racing on pods.
`kubectl wait --for=jsonpath` fails immediately with "status is not found" when the ECK operator has not written the Elasticsearch `.status` subresource yet (it does so asynchronously after apply). Replace it with a polling loop that waits until `.status.phase` reaches `Ready`, logging the phase on each iteration for easier debugging.
MYilFun00
changed the title
kenza244
approved these changes
Jul 6, 2026
MYilFun00
added a commit
to piptouque/ralph
that referenced
this pull request
Jul 6, 2026
Reconcile with main (openfun#632, openfun#634, openfun#635) and resolve CHANGELOG conflict. Co-authored-by: Cursor <cursoragent@cursor.com>
MYilFun00
added a commit
to piptouque/ralph
that referenced
this pull request
Jul 6, 2026
Reconcile with main (openfun#632, openfun#634, openfun#635) and resolve CHANGELOG conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The CI pipeline is currently red for reasons unrelated to any feature change:
check-changelogjob runsgit whatchanged, which recent Git versions(>= 2.47) refuse to run (
fatal: refusing to run without --i-still-use-this),so the job fails on every branch.
string. That wording changed across pymongo versions, so the tests fail
depending on the resolved pymongo version.
trayjob runs Arnold from the unpinnedmasterimage tag.mastermoved to 6.24.0 (ansible-core 2.14.18), whose stricter vault handling breaks
the "Decrypt vaulted credentials" step (green->red on unrelated PRs).
test-helmjob installs the ECK operator from an unpinned chart and thenwaits on pods with a short
sleep. The freshly installed operator is notready yet, so no pods exist and
kubectl waitfails immediately(
no matching resources found, thenstatus is not found).This PR restores a green pipeline so functional PRs can be validated on a
reliable CI signal.
Proposal
git whatchanged --name-only --pretty="" origin..HEADwithgit log --name-only --pretty=format: origin..HEADin thecheck-changelogjob (.circleci/config.yml).test_backends_data_mongo_write_with_delete_operation_failureand itsasync counterpart assert only on the stable, Ralph-controlled prefix
"Failed to delete document chunk: "instead of the full pymongo/bsonmessage.
6.23.0(the last release before the ansible-core 2.14.18regression) in
Makefileand.k3d-cluster.env.sh, and fetch thebin/arnold/bin/init-clusterwrappers from thev6.23.0tag.test-helmElasticsearch deployment: pineck-operatorto2.16.1, wait for the operator to be ready before applying theElasticsearchresource, and poll.status.phaseuntilReadyinsteadof racing on pods.
CHANGELOG.md.Testing
1793 passed, 6 skipped(previously
2 failed, 1791 passed).check-changelogcommand detects aCHANGELOG.mdchange.trayfailure locally and confirmed the ansible-core2.14.17 -> 2.14.18 bump (Arnold 6.23.0 -> 6.24.0) is the trigger.
trayandtest-helmare now green on CircleCI.